mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
102 lines
3.7 KiB
Python
102 lines
3.7 KiB
Python
"""Tests for gateway.run._check_unavailable_skill.
|
|
|
|
Regression coverage for the dir-name-vs-frontmatter-name drift bug.
|
|
The hint function used to compare the skill's parent-directory name
|
|
against the typed command and the disabled list. That silently missed
|
|
every skill whose directory name differs from its declared frontmatter
|
|
name (~19 skills on a standard install), so users typing a real slug
|
|
like ``/stable-diffusion-image-generation`` got a generic "unknown
|
|
command" response instead of the intended "disabled — enable with …"
|
|
or "not installed — install with …" hint.
|
|
|
|
These tests pin the fixed behavior:
|
|
|
|
* Slug is derived from the frontmatter ``name:`` (exactly matching
|
|
:func:`agent.skill_commands.scan_skill_commands`), so the slug differs
|
|
from the directory name when the declared name is multi-word.
|
|
* ``disabled`` membership is checked by the declared name, because that
|
|
is what :func:`hermes_cli.skills_config.save_disabled_skills` stores.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def tmp_skills(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> Path:
|
|
"""Isolated skills dir + HERMES_HOME so the real user config is untouched."""
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
(home / "skills").mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
return home / "skills"
|
|
|
|
|
|
def _write_skill(skills_dir: Path, rel: str, frontmatter_name: str) -> Path:
|
|
"""Create a SKILL.md at ``<skills_dir>/<rel>/SKILL.md``."""
|
|
skill_dir = skills_dir / rel
|
|
skill_dir.mkdir(parents=True, exist_ok=True)
|
|
skill_md = skill_dir / "SKILL.md"
|
|
skill_md.write_text(
|
|
f"---\nname: {frontmatter_name}\ndescription: test skill\n---\nBody.\n",
|
|
encoding="utf-8",
|
|
)
|
|
return skill_md
|
|
|
|
|
|
def test_frontmatter_slug_matched_even_when_dir_name_differs(
|
|
tmp_skills: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""Directory ``stable-diffusion`` + frontmatter ``Stable Diffusion Image Generation``.
|
|
|
|
Command typed: ``stable-diffusion-image-generation`` (the slug the
|
|
agent actually registers). The old dir-name-based check would have
|
|
compared ``stable-diffusion`` to the typed command and missed.
|
|
"""
|
|
from gateway import run as gateway_run
|
|
|
|
_write_skill(tmp_skills, "mlops/stable-diffusion", "Stable Diffusion Image Generation")
|
|
|
|
# Config disables by declared name (matches what `hermes skills config` writes).
|
|
monkeypatch.setattr(
|
|
"gateway.run._get_disabled_skill_names",
|
|
lambda: {"Stable Diffusion Image Generation"},
|
|
raising=False,
|
|
)
|
|
with patch(
|
|
"tools.skills_tool._get_disabled_skill_names",
|
|
return_value={"Stable Diffusion Image Generation"},
|
|
), patch(
|
|
"agent.skill_utils.get_all_skills_dirs",
|
|
return_value=[tmp_skills],
|
|
):
|
|
msg = gateway_run._check_unavailable_skill("stable-diffusion-image-generation")
|
|
|
|
assert msg is not None, (
|
|
"expected a 'disabled' hint for the frontmatter-derived slug; "
|
|
"the old code compared the dir name 'stable-diffusion' and returned None"
|
|
)
|
|
assert "disabled" in msg.lower()
|
|
assert "hermes skills config" in msg
|
|
|
|
|
|
def test_unknown_command_still_returns_none(
|
|
tmp_skills: Path,
|
|
) -> None:
|
|
"""A command that matches no on-disk skill still returns None."""
|
|
from gateway import run as gateway_run
|
|
|
|
_write_skill(tmp_skills, "creative/ascii-art", "ascii-art")
|
|
|
|
with patch(
|
|
"tools.skills_tool._get_disabled_skill_names", return_value=set()
|
|
), patch(
|
|
"agent.skill_utils.get_all_skills_dirs", return_value=[tmp_skills]
|
|
):
|
|
assert gateway_run._check_unavailable_skill("no-such-skill") is None
|
|
|
|
|