mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
37 lines
1.4 KiB
Python
37 lines
1.4 KiB
Python
"""Regression test for TUI approval-prompt credential redaction (#48456).
|
|
|
|
Follow-up to #50767, which redacted the chat-platform and SSE/API approval
|
|
transports. The TUI JSON-RPC transport is the third egress: three
|
|
`register_gateway_notify` callbacks in `tui_gateway/server.py` emit the raw
|
|
`approval_data` (with an unredacted `command`) to the TUI client. They now
|
|
route through the module-level `_emit_approval_request` helper, which redacts
|
|
`payload["command"]` via the shared `gateway.run._redact_approval_command` seam
|
|
before emitting.
|
|
"""
|
|
|
|
import inspect
|
|
|
|
import pytest
|
|
|
|
|
|
class TestTuiApprovalEmitRedaction:
|
|
def test_emit_approval_request_redacts_command_in_payload(self, monkeypatch):
|
|
from tui_gateway import server as tui_server
|
|
|
|
emitted = {}
|
|
monkeypatch.setattr(
|
|
tui_server, "_emit",
|
|
lambda event, sid, payload=None: emitted.update(
|
|
{"event": event, "sid": sid, "payload": payload}
|
|
),
|
|
)
|
|
raw = "curl -H 'Authorization: token ghp_01...6789' https://api.github.com"
|
|
tui_server._emit_approval_request("sess-1", {"command": raw, "description": "x"})
|
|
|
|
assert emitted["event"] == "approval.request"
|
|
# credential removed, non-command field + command structure preserved
|
|
assert "ghp_01...6789" not in emitted["payload"]["command"]
|
|
assert emitted["payload"]["description"] == "x"
|
|
assert "github.com" in emitted["payload"]["command"]
|
|
|
|
|