mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
68 lines
2.6 KiB
Python
68 lines
2.6 KiB
Python
"""Tests for GHSA-3vpc-7q5r-276h — Telegram webhook secret required.
|
|
|
|
Previously, when TELEGRAM_WEBHOOK_URL was set but TELEGRAM_WEBHOOK_SECRET
|
|
was not, python-telegram-bot received secret_token=None and the webhook
|
|
endpoint accepted any HTTP POST.
|
|
|
|
The fix refuses to start the adapter in webhook mode without the secret.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
|
|
_repo = str(Path(__file__).resolve().parents[2])
|
|
if _repo not in sys.path:
|
|
sys.path.insert(0, _repo)
|
|
|
|
|
|
class TestTelegramWebhookSecretRequired:
|
|
"""Direct source-level check of the webhook-secret guard.
|
|
|
|
The guard is embedded in TelegramAdapter.connect() and hard to isolate
|
|
via mocks (requires a full python-telegram-bot ApplicationBuilder
|
|
chain). These tests exercise it via source inspection — verifying the
|
|
check exists, raises RuntimeError with the advisory link, and only
|
|
fires in webhook mode. End-to-end validation is covered by CI +
|
|
manual deployment tests.
|
|
"""
|
|
|
|
def _get_source(self) -> str:
|
|
path = Path(_repo) / "plugins" / "platforms" / "telegram" / "adapter.py"
|
|
return path.read_text(encoding="utf-8")
|
|
|
|
def test_webhook_branch_checks_secret(self):
|
|
"""The webhook-mode branch of connect() must read
|
|
TELEGRAM_WEBHOOK_SECRET and refuse when empty."""
|
|
src = self._get_source()
|
|
# The guard must appear after TELEGRAM_WEBHOOK_URL is set
|
|
assert re.search(
|
|
r'TELEGRAM_WEBHOOK_SECRET.*?\.strip\(\)\s*\n\s*if not webhook_secret:',
|
|
src, re.DOTALL,
|
|
), (
|
|
"TelegramAdapter.connect() must strip TELEGRAM_WEBHOOK_SECRET "
|
|
"and raise when the secret is empty — see GHSA-3vpc-7q5r-276h"
|
|
)
|
|
|
|
|
|
def test_polling_branch_has_no_secret_guard(self):
|
|
"""Polling mode (else-branch) must NOT require the webhook secret —
|
|
polling authenticates via the bot token, not a webhook secret."""
|
|
src = self._get_source()
|
|
# The guard should appear inside the `if webhook_url:` branch,
|
|
# not the `else:` polling branch. Rough check: the raise is
|
|
# followed (within ~60 lines) by an `else:` that starts the
|
|
# polling branch, and there's no secret-check in that polling
|
|
# branch.
|
|
webhook_block = re.search(
|
|
r'if webhook_url:\s*\n(.*?)\n else:\s*\n(.*?)\n',
|
|
src, re.DOTALL,
|
|
)
|
|
if webhook_block:
|
|
webhook_body = webhook_block.group(1)
|
|
polling_body = webhook_block.group(2)
|
|
assert "TELEGRAM_WEBHOOK_SECRET" in webhook_body
|
|
assert "TELEGRAM_WEBHOOK_SECRET" not in polling_body
|