mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
66 lines
2.1 KiB
Python
66 lines
2.1 KiB
Python
"""Tests for the Telegram bot status indicator.
|
|
|
|
Telegram bots have no real online/offline presence dot (that's a user-account
|
|
feature). The closest Bot API surface is the bot's *short description* — the
|
|
line shown under the bot's name in its profile. When `extra.status_indicator`
|
|
is enabled, the adapter sets it to "Online" on connect and "Offline" on clean
|
|
disconnect so users can tell whether the gateway is up.
|
|
"""
|
|
|
|
import sys
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
|
|
from gateway.config import PlatformConfig
|
|
|
|
|
|
def _ensure_telegram_mock():
|
|
if "telegram" in sys.modules and hasattr(sys.modules["telegram"], "__file__"):
|
|
return
|
|
|
|
telegram_mod = MagicMock()
|
|
telegram_mod.ext.ContextTypes.DEFAULT_TYPE = type(None)
|
|
telegram_mod.constants.ParseMode.MARKDOWN_V2 = "MarkdownV2"
|
|
telegram_mod.constants.ChatType.GROUP = "group"
|
|
telegram_mod.constants.ChatType.SUPERGROUP = "supergroup"
|
|
telegram_mod.constants.ChatType.CHANNEL = "channel"
|
|
telegram_mod.constants.ChatType.PRIVATE = "private"
|
|
|
|
for name in ("telegram", "telegram.ext", "telegram.constants", "telegram.request"):
|
|
sys.modules.setdefault(name, telegram_mod)
|
|
|
|
|
|
_ensure_telegram_mock()
|
|
|
|
from plugins.platforms.telegram.adapter import TelegramAdapter # noqa: E402
|
|
|
|
|
|
def _make_adapter(extra):
|
|
adapter = TelegramAdapter(PlatformConfig(enabled=True, token="***", extra=extra))
|
|
adapter._bot = MagicMock()
|
|
adapter._bot.set_my_short_description = AsyncMock()
|
|
return adapter
|
|
|
|
|
|
def test_enabled_via_extra():
|
|
adapter = _make_adapter(extra={"status_indicator": True})
|
|
assert adapter._status_indicator_enabled is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_disabled_is_noop():
|
|
adapter = _make_adapter(extra={"status_indicator": False})
|
|
await adapter._set_status_indicator(online=True)
|
|
adapter._bot.set_my_short_description.assert_not_called()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_online_sets_default_text():
|
|
adapter = _make_adapter(extra={"status_indicator": True})
|
|
await adapter._set_status_indicator(online=True)
|
|
adapter._bot.set_my_short_description.assert_awaited_once_with(
|
|
short_description="Online"
|
|
)
|
|
|
|
|