mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
78 lines
3.1 KiB
Python
78 lines
3.1 KiB
Python
"""Tests for rich-message newline normalization (issue #46070).
|
|
|
|
When Bot API 10.1 ``sendRichMessage`` is available, slash-command responses
|
|
are sent through the rich path with RAW markdown. Standard Markdown treats
|
|
a lone ``\\n`` as a soft line break (renders as whitespace), so multi-line
|
|
command output collapses into a single paragraph on Telegram.
|
|
|
|
``_rich_message_payload`` must normalize single newlines to Markdown hard
|
|
breaks (two trailing spaces + ``\\n``) so they render as visible line breaks.
|
|
Paragraph breaks (``\\n\\n``) and fenced code blocks must be preserved.
|
|
|
|
The ``telegram`` package is mocked by ``tests/gateway/conftest.py``, so these
|
|
tests construct a real ``TelegramAdapter``.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from plugins.platforms.telegram.adapter import TelegramAdapter
|
|
|
|
|
|
@pytest.fixture()
|
|
def adapter():
|
|
"""Bare adapter instance — _rich_message_payload doesn't use self."""
|
|
return object.__new__(TelegramAdapter)
|
|
|
|
|
|
class TestRichMessageNewlineNormalization:
|
|
"""Verify _rich_message_payload normalizes single \\n to hard breaks."""
|
|
|
|
def test_single_newlines_become_hard_breaks(self, adapter):
|
|
"""A lone \\n must gain two trailing spaces (Markdown hard break).
|
|
|
|
Standard Markdown soft-break rendering causes Bot API 10.1
|
|
``sendRichMessage`` to collapse multi-line content into one paragraph.
|
|
"""
|
|
content = "Line 1\nLine 2\nLine 3"
|
|
payload = adapter._rich_message_payload(content)
|
|
md = payload["markdown"]
|
|
# Each single \n should now be " \n" (two spaces + newline)
|
|
assert " \n" in md, f"Expected hard break ' \\n' in {md!r}"
|
|
assert "Line 1 \nLine 2 \nLine 3" == md
|
|
|
|
def test_paragraph_breaks_preserved(self, adapter):
|
|
"""Double newlines (paragraph breaks) must NOT gain extra spaces."""
|
|
content = "Paragraph 1\n\nParagraph 2"
|
|
payload = adapter._rich_message_payload(content)
|
|
md = payload["markdown"]
|
|
# \n\n should remain as-is — no trailing spaces injected
|
|
assert "Paragraph 1\n\nParagraph 2" == md
|
|
|
|
def test_mixed_single_and_double_newlines(self, adapter):
|
|
"""Content with both list items and paragraph breaks must be handled correctly."""
|
|
content = (
|
|
"Header\n\n"
|
|
"`/new` -- Start\n"
|
|
"`/model` -- Switch\n"
|
|
"`/reset` -- Reset\n\n"
|
|
"Footer"
|
|
)
|
|
payload = adapter._rich_message_payload(content)
|
|
md = payload["markdown"]
|
|
# Paragraph breaks preserved
|
|
assert "Header\n\n" in md
|
|
assert "\n\nFooter" in md
|
|
# Single newlines converted to hard breaks
|
|
assert "`/new` -- Start \n`/model` -- Switch \n`/reset` -- Reset" in md
|
|
|
|
|
|
class TestRichMessageTableProtection:
|
|
"""Hard-break injection must not corrupt GFM tables (rendered natively)."""
|
|
|
|
def test_table_rows_keep_bare_newlines(self, adapter):
|
|
"""Table block newlines must stay bare — no ' \\n' inside the table."""
|
|
content = "| Col A | Col B |\n|-------|-------|\n| 1 | 2 |\n| 3 | 4 |"
|
|
md = adapter._rich_message_payload(content)["markdown"]
|
|
assert " \n" not in md
|
|
assert md == content
|
|
|