mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
96 lines
2.9 KiB
Python
96 lines
2.9 KiB
Python
"""Tests for Telegram native partial-quote handling in _build_message_event.
|
|
|
|
When a Telegram user replies using Telegram's native quote feature to
|
|
select only part of a prior message, the adapter must use ``message.quote.text``
|
|
(the user-selected substring) rather than ``message.reply_to_message.text``
|
|
(the entire replied-to message). Otherwise the agent receives the full prior
|
|
message as ``reply_to_text``, which can cause it to act on unrelated
|
|
actionable-looking text the user did not quote (#22619).
|
|
"""
|
|
|
|
import sys
|
|
from types import SimpleNamespace
|
|
from unittest.mock import MagicMock
|
|
|
|
from gateway.config import PlatformConfig
|
|
|
|
|
|
def _ensure_telegram_mock():
|
|
if "telegram" in sys.modules and hasattr(sys.modules["telegram"], "__file__"):
|
|
return
|
|
|
|
telegram_mod = MagicMock()
|
|
telegram_mod.ext.ContextTypes.DEFAULT_TYPE = type(None)
|
|
telegram_mod.constants.ParseMode.MARKDOWN_V2 = "MarkdownV2"
|
|
telegram_mod.constants.ChatType.GROUP = "group"
|
|
telegram_mod.constants.ChatType.SUPERGROUP = "supergroup"
|
|
telegram_mod.constants.ChatType.CHANNEL = "channel"
|
|
telegram_mod.constants.ChatType.PRIVATE = "private"
|
|
|
|
for name in ("telegram", "telegram.ext", "telegram.constants", "telegram.request"):
|
|
sys.modules.setdefault(name, telegram_mod)
|
|
|
|
|
|
_ensure_telegram_mock()
|
|
|
|
from plugins.platforms.telegram.adapter import TelegramAdapter # noqa: E402
|
|
|
|
|
|
def _make_adapter():
|
|
return TelegramAdapter(PlatformConfig(enabled=True, token="***", extra={}))
|
|
|
|
|
|
def _make_message(
|
|
text="follow-up",
|
|
reply_to_text=None,
|
|
reply_to_caption=None,
|
|
reply_to_id=42,
|
|
quote_text=None,
|
|
):
|
|
chat = SimpleNamespace(id=111, type="private", title=None, full_name="Alice")
|
|
user = SimpleNamespace(id=42, full_name="Alice")
|
|
|
|
reply_to_message = None
|
|
if reply_to_text is not None or reply_to_caption is not None:
|
|
reply_to_message = SimpleNamespace(
|
|
message_id=reply_to_id,
|
|
text=reply_to_text,
|
|
caption=reply_to_caption,
|
|
)
|
|
|
|
quote = None
|
|
if quote_text is not None:
|
|
quote = SimpleNamespace(text=quote_text)
|
|
|
|
return SimpleNamespace(
|
|
chat=chat,
|
|
from_user=user,
|
|
text=text,
|
|
message_thread_id=None,
|
|
message_id=1001,
|
|
reply_to_message=reply_to_message,
|
|
quote=quote,
|
|
date=None,
|
|
forum_topic_created=None,
|
|
)
|
|
|
|
|
|
def test_native_partial_quote_used_as_reply_to_text():
|
|
"""When ``message.quote`` is present, prefer the selected substring."""
|
|
from gateway.platforms.base import MessageType
|
|
|
|
adapter = _make_adapter()
|
|
msg = _make_message(
|
|
text="mark this one as done",
|
|
reply_to_text=(
|
|
"Briefing:\n- Item A: deploy fix\n- Item B: rotate keys\n- Item C: update docs"
|
|
),
|
|
quote_text="Item B: rotate keys",
|
|
)
|
|
|
|
event = adapter._build_message_event(msg, MessageType.TEXT)
|
|
|
|
assert event.reply_to_text == "Item B: rotate keys"
|
|
assert event.reply_to_message_id == "42"
|
|
|
|
|