mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
50 lines
1.7 KiB
Python
50 lines
1.7 KiB
Python
"""Regression coverage for partial Telegram overflow delivery."""
|
|
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
|
|
from gateway.config import PlatformConfig
|
|
from gateway.platforms.base import SendResult
|
|
from plugins.platforms.telegram.adapter import TelegramAdapter
|
|
from gateway.stream_consumer import GatewayStreamConsumer
|
|
|
|
|
|
def _message(message_id: int | str) -> SimpleNamespace:
|
|
return SimpleNamespace(message_id=message_id)
|
|
|
|
|
|
@pytest.fixture
|
|
def telegram_adapter() -> TelegramAdapter:
|
|
adapter = TelegramAdapter(PlatformConfig(enabled=True, token="fake-token"))
|
|
adapter._bot = MagicMock()
|
|
object.__setattr__(adapter, "MAX_MESSAGE_LENGTH", 160)
|
|
return adapter
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_edit_overflow_split_reports_later_partial_failure_after_some_continuations_land(telegram_adapter):
|
|
"""Partial metadata tracks the last delivered continuation before failure."""
|
|
content = "word " * 120
|
|
telegram_adapter._bot.edit_message_text = AsyncMock(return_value=True)
|
|
telegram_adapter._bot.send_message = AsyncMock(
|
|
side_effect=[
|
|
_message(202),
|
|
RuntimeError("telegram send failed"),
|
|
RuntimeError("telegram send failed"),
|
|
]
|
|
)
|
|
|
|
result = await telegram_adapter._edit_overflow_split(
|
|
"12345", "201", content, finalize=False, metadata={"thread_id": "77"}
|
|
)
|
|
|
|
assert result.success is False
|
|
assert result.message_id == "202"
|
|
assert result.raw_response["partial_overflow"] is True
|
|
assert result.raw_response["delivered_chunks"] == 2
|
|
assert result.raw_response["last_message_id"] == "202"
|
|
assert result.continuation_message_ids == ("202",)
|
|
|
|
|