mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
85 lines
3.2 KiB
Python
85 lines
3.2 KiB
Python
"""Tests for lazy forum command registration in TelegramAdapter."""
|
|
|
|
import asyncio
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from gateway.config import Platform, PlatformConfig
|
|
|
|
|
|
def _make_test_adapter():
|
|
"""Build a TelegramAdapter without running __init__."""
|
|
from plugins.platforms.telegram.adapter import TelegramAdapter
|
|
|
|
adapter = object.__new__(TelegramAdapter)
|
|
adapter.platform = Platform.TELEGRAM
|
|
adapter.config = PlatformConfig(enabled=True, token="***", extra={})
|
|
# ``name`` is a property derived from platform.value.title()
|
|
adapter._bot = MagicMock()
|
|
adapter._bot.set_my_commands = AsyncMock()
|
|
adapter._forum_command_registered = set()
|
|
adapter._forum_lock = asyncio.Lock()
|
|
return adapter
|
|
|
|
|
|
def _forum_message(chat_id=-100, is_forum=True):
|
|
return SimpleNamespace(
|
|
chat=SimpleNamespace(id=chat_id, is_forum=is_forum),
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_ensure_forum_commands_registers_once():
|
|
adapter = _make_test_adapter()
|
|
msg = _forum_message(chat_id=-123, is_forum=True)
|
|
|
|
with patch("hermes_cli.commands.telegram_menu_commands") as mock_menu:
|
|
mock_menu.return_value = ([("new", "Start new session"), ("help", "Show help")], 0)
|
|
with patch("telegram.BotCommand") as MockBotCommand:
|
|
instances = []
|
|
|
|
def _make_cmd(name, desc):
|
|
cmd = MagicMock()
|
|
cmd.name = name
|
|
cmd.description = desc
|
|
instances.append(cmd)
|
|
return cmd
|
|
|
|
MockBotCommand.side_effect = _make_cmd
|
|
with patch("telegram.BotCommandScopeChat") as MockScope:
|
|
# Track the chat_id passed to the BotCommandScopeChat constructor
|
|
# so the assertions below see an int instead of a bare MagicMock.
|
|
def _make_scope(chat_id):
|
|
s = MagicMock()
|
|
s.chat_id = chat_id
|
|
return s
|
|
MockScope.side_effect = _make_scope
|
|
await adapter._ensure_forum_commands(msg)
|
|
|
|
assert -123 in adapter._forum_command_registered
|
|
adapter._bot.set_my_commands.assert_awaited_once()
|
|
args, kwargs = adapter._bot.set_my_commands.call_args
|
|
assert len(args[0]) == 2 # two BotCommand instances
|
|
assert kwargs["scope"] is not None
|
|
assert isinstance(kwargs["scope"].chat_id, int)
|
|
assert kwargs["scope"].chat_id == -123
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_ensure_forum_commands_race_safety():
|
|
"""Two concurrent coroutines must not double-register the same chat."""
|
|
adapter = _make_test_adapter()
|
|
msg = _forum_message(chat_id=-789, is_forum=True)
|
|
|
|
with patch("hermes_cli.commands.telegram_menu_commands") as mock_menu:
|
|
mock_menu.return_value = ([("new", "Start new session")], 0)
|
|
with patch("telegram.BotCommand"):
|
|
with patch("telegram.BotCommandScopeChat"):
|
|
coro1 = adapter._ensure_forum_commands(msg)
|
|
coro2 = adapter._ensure_forum_commands(msg)
|
|
await asyncio.gather(coro1, coro2)
|
|
|
|
# The lock should make this exactly 1 call, not 2.
|
|
assert adapter._bot.set_my_commands.await_count == 1
|