mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
89 lines
3.1 KiB
Python
89 lines
3.1 KiB
Python
"""Tests for Telegram adapter fail-closed auth fallback (#24457).
|
|
|
|
The _is_callback_user_authorized fallback must deny users by default
|
|
when TELEGRAM_ALLOWED_USERS is empty, instead of allowing everyone.
|
|
"""
|
|
|
|
import sys
|
|
import types
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
from gateway.config import PlatformConfig, Platform
|
|
|
|
|
|
# -- Fake telegram modules (minimal stubs) --------------------------------
|
|
|
|
_fake_telegram_error = types.ModuleType("telegram.error")
|
|
|
|
|
|
class _TelegramError(Exception):
|
|
pass
|
|
|
|
|
|
_fake_telegram_error.TelegramError = _TelegramError
|
|
_fake_telegram_error.BadRequest = type("BadRequest", (_TelegramError,), {})
|
|
_fake_telegram_error.NetworkError = type("NetworkError", (_TelegramError,), {})
|
|
|
|
_fake_telegram_constants = types.ModuleType("telegram.constants")
|
|
_fake_telegram_constants.ParseMode = SimpleNamespace(HTML="HTML")
|
|
|
|
_fake_telegram_request = types.ModuleType("telegram.request")
|
|
_fake_telegram_request.HTTPXRequest = type("HTTPXRequest", (), {"__init__": lambda *a, **kw: None})
|
|
|
|
_fake_telegram_ext = types.ModuleType("telegram.ext")
|
|
_fake_telegram_ext.ApplicationBuilder = type("ApplicationBuilder", (), {
|
|
"token": lambda self, *a: self,
|
|
"build": lambda self: None,
|
|
})
|
|
|
|
_fake_telegram = types.ModuleType("telegram")
|
|
_fake_telegram.error = _fake_telegram_error
|
|
_fake_telegram.constants = _fake_telegram_constants
|
|
_fake_telegram.ext = _fake_telegram_ext
|
|
_fake_telegram.request = _fake_telegram_request
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _inject_fake_telegram(monkeypatch):
|
|
monkeypatch.setitem(sys.modules, "telegram", _fake_telegram)
|
|
monkeypatch.setitem(sys.modules, "telegram.error", _fake_telegram_error)
|
|
monkeypatch.setitem(sys.modules, "telegram.constants", _fake_telegram_constants)
|
|
monkeypatch.setitem(sys.modules, "telegram.ext", _fake_telegram_ext)
|
|
monkeypatch.setitem(sys.modules, "telegram.request", _fake_telegram_request)
|
|
|
|
|
|
def _make_adapter():
|
|
from plugins.platforms.telegram.adapter import TelegramAdapter
|
|
|
|
config = PlatformConfig(enabled=True, token="fake-token")
|
|
adapter = object.__new__(TelegramAdapter)
|
|
adapter.config = config
|
|
adapter._config = config
|
|
adapter._platform = Platform.TELEGRAM
|
|
adapter._connected = True
|
|
return adapter
|
|
|
|
|
|
class TestCallbackAuthFailClosed:
|
|
"""_is_callback_user_authorized fallback must be fail-closed."""
|
|
|
|
def test_no_allowlist_no_allow_all_denies(self, monkeypatch):
|
|
"""No TELEGRAM_ALLOWED_USERS and no GATEWAY_ALLOW_ALL_USERS → deny."""
|
|
monkeypatch.delenv("TELEGRAM_ALLOWED_USERS", raising=False)
|
|
monkeypatch.delenv("GATEWAY_ALLOW_ALL_USERS", raising=False)
|
|
adapter = _make_adapter()
|
|
# Force the fallback path (no runner auth)
|
|
adapter._message_handler = None
|
|
assert adapter._is_callback_user_authorized("12345") is False
|
|
|
|
|
|
def test_allowlist_with_matching_user_permits(self, monkeypatch):
|
|
"""TELEGRAM_ALLOWED_USERS contains the user → allow."""
|
|
monkeypatch.setenv("TELEGRAM_ALLOWED_USERS", "12345,67890")
|
|
adapter = _make_adapter()
|
|
adapter._message_handler = None
|
|
assert adapter._is_callback_user_authorized("12345") is True
|
|
|
|
|