mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
129 lines
3.8 KiB
Python
129 lines
3.8 KiB
Python
"""Regression guard for Telegram bot-origin authorization (#32188)."""
|
|
|
|
from types import SimpleNamespace
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from gateway.session import Platform, SessionSource
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _isolate_telegram_env(monkeypatch):
|
|
for var in (
|
|
"TELEGRAM_ALLOW_BOTS",
|
|
"TELEGRAM_ALLOWED_USERS",
|
|
"TELEGRAM_ALLOW_ALL_USERS",
|
|
"TELEGRAM_GROUP_ALLOWED_USERS",
|
|
"TELEGRAM_GROUP_ALLOWED_CHATS",
|
|
"GATEWAY_ALLOW_ALL_USERS",
|
|
"GATEWAY_ALLOWED_USERS",
|
|
):
|
|
monkeypatch.delenv(var, raising=False)
|
|
|
|
|
|
def _make_bare_runner():
|
|
from gateway.run import GatewayRunner
|
|
|
|
runner = object.__new__(GatewayRunner)
|
|
runner.pairing_store = SimpleNamespace(is_approved=lambda *_a, **_kw: False)
|
|
return runner
|
|
|
|
|
|
def _make_telegram_bot_source(bot_id: str = "999888777"):
|
|
return SessionSource(
|
|
platform=Platform.TELEGRAM,
|
|
chat_id="123",
|
|
chat_type="dm",
|
|
user_id=bot_id,
|
|
user_name="OtherProfileBot",
|
|
is_bot=True,
|
|
)
|
|
|
|
|
|
def _make_telegram_human_source(user_id: str = "100200300"):
|
|
return SessionSource(
|
|
platform=Platform.TELEGRAM,
|
|
chat_id="123",
|
|
chat_type="dm",
|
|
user_id=user_id,
|
|
user_name="SomeHuman",
|
|
is_bot=False,
|
|
)
|
|
|
|
|
|
def test_telegram_bot_authorized_when_allow_bots_mentions(monkeypatch):
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("TELEGRAM_ALLOW_BOTS", "mentions")
|
|
monkeypatch.setenv("TELEGRAM_ALLOWED_USERS", "100200300")
|
|
|
|
assert runner._is_user_authorized(_make_telegram_bot_source("999888777")) is True
|
|
|
|
|
|
def test_telegram_human_still_checked_against_allowlist_when_bot_policy_set(monkeypatch):
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("TELEGRAM_ALLOW_BOTS", "all")
|
|
monkeypatch.setenv("TELEGRAM_ALLOWED_USERS", "100200300")
|
|
|
|
assert runner._is_user_authorized(_make_telegram_human_source("999999999")) is False
|
|
assert runner._is_user_authorized(_make_telegram_human_source("100200300")) is True
|
|
|
|
|
|
def _build_telegram_message(*, is_bot: bool):
|
|
user = SimpleNamespace(
|
|
id=999888777 if is_bot else 100200300,
|
|
full_name="OtherProfileBot" if is_bot else "Alice",
|
|
is_bot=is_bot,
|
|
)
|
|
chat = SimpleNamespace(
|
|
id=123,
|
|
type="private",
|
|
title=None,
|
|
full_name="Alice",
|
|
is_forum=False,
|
|
)
|
|
message = MagicMock()
|
|
message.from_user = user
|
|
message.chat = chat
|
|
message.message_id = 4242
|
|
message.message_thread_id = None
|
|
message.is_topic_message = False
|
|
message.forum_topic_created = None
|
|
message.reply_to_message = None
|
|
message.quote = None
|
|
message.text = "hello"
|
|
message.caption = None
|
|
return message
|
|
|
|
|
|
def _capture_build_source_is_bot(is_bot: bool):
|
|
from gateway.platforms.base import MessageType
|
|
from plugins.platforms.telegram.adapter import TelegramAdapter
|
|
|
|
adapter = object.__new__(TelegramAdapter)
|
|
adapter.platform = Platform.TELEGRAM
|
|
adapter.config = SimpleNamespace(extra={})
|
|
message = _build_telegram_message(is_bot=is_bot)
|
|
captured: dict = {}
|
|
|
|
def fake_build_source(**kwargs):
|
|
captured.update(kwargs)
|
|
return SessionSource(
|
|
platform=Platform.TELEGRAM,
|
|
chat_id=str(kwargs.get("chat_id") or ""),
|
|
chat_type=kwargs.get("chat_type") or "dm",
|
|
user_id=kwargs.get("user_id"),
|
|
is_bot=kwargs.get("is_bot", False),
|
|
)
|
|
|
|
with patch.object(adapter, "build_source", side_effect=fake_build_source):
|
|
try:
|
|
adapter._build_message_event(message, MessageType.TEXT, update_id=1)
|
|
except Exception:
|
|
# The method may continue into PTB-specific optional fields after
|
|
# source construction; this test only pins the source kwarg.
|
|
pass
|
|
|
|
return captured.get("is_bot")
|
|
|
|
|