mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
70 lines
2 KiB
Python
70 lines
2 KiB
Python
"""Shared GFM table → bullet conversion helpers."""
|
|
|
|
from gateway.platforms.helpers import (
|
|
TABLE_SEPARATOR_RE,
|
|
is_table_row,
|
|
split_markdown_table_row,
|
|
convert_table_to_bullets,
|
|
)
|
|
|
|
|
|
class TestTablePrimitives:
|
|
|
|
def test_separator_re_matches_basic(self):
|
|
assert TABLE_SEPARATOR_RE.match("|---|---|")
|
|
|
|
|
|
def test_is_table_row_with_pipe(self):
|
|
assert is_table_row("| Alice | 150 |")
|
|
|
|
|
|
class TestConvertTableToBullets:
|
|
|
|
def test_basic_table(self):
|
|
text = (
|
|
"| Player | Score |\n"
|
|
"|--------|-------|\n"
|
|
"| Alice | 150 |\n"
|
|
"| Bob | 120 |"
|
|
)
|
|
out = convert_table_to_bullets(text)
|
|
assert "**Alice**" in out
|
|
assert "• Score: 150" in out
|
|
assert "**Bob**" in out
|
|
assert "• Score: 120" in out
|
|
assert "• Player: Alice" not in out
|
|
|
|
def test_three_column_table(self):
|
|
text = (
|
|
"| Name | Age | City |\n"
|
|
"|:-----|----:|:----:|\n"
|
|
"| Ada | 30 | NYC |"
|
|
)
|
|
out = convert_table_to_bullets(text)
|
|
assert "**Ada**" in out
|
|
assert "• Name: Ada" not in out
|
|
assert "• Age: 30" in out
|
|
assert "• City: NYC" in out
|
|
assert "**Ada**\n• Age: 30\n• City: NYC" in out
|
|
|
|
def test_row_label_column(self):
|
|
text = (
|
|
"| | Score | Rank |\n"
|
|
"|--------|-------|------|\n"
|
|
"| Alice | 150 | 1 |\n"
|
|
"| Bob | 120 | 2 |"
|
|
)
|
|
out = convert_table_to_bullets(text)
|
|
assert "**Alice**" in out
|
|
assert "• Score: 150" in out
|
|
assert "• Rank: 1" in out
|
|
assert "**Alice**\n• Score: 150\n• Rank: 1" in out
|
|
|
|
def test_bare_pipe_table(self):
|
|
text = "head1 | head2\n--- | ---\na | b\nc | d"
|
|
out = convert_table_to_bullets(text)
|
|
assert "**a**" in out
|
|
assert "• head1: a" not in out
|
|
assert "• head2: b" in out
|
|
|
|
|