mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
54 lines
1.5 KiB
Python
54 lines
1.5 KiB
Python
"""Gateway lifecycle contract for the opt-in systemd watchdog."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import inspect
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from gateway.config import GatewayConfig
|
|
from gateway.run import GatewayRunner, start_gateway
|
|
from tests.gateway.restart_test_helpers import make_restart_runner
|
|
|
|
|
|
class _FakeWatchdog:
|
|
instances: list["_FakeWatchdog"] = []
|
|
|
|
def __init__(self, *, config_enabled: bool = True):
|
|
self.config_enabled = config_enabled
|
|
self.calls: list[str] = []
|
|
self.__class__.instances.append(self)
|
|
|
|
def start(self) -> bool:
|
|
self.calls.append("start")
|
|
return self.config_enabled
|
|
|
|
def ready(self, status: str) -> bool:
|
|
self.calls.append(f"ready:{status}")
|
|
return True
|
|
|
|
async def stop(self) -> None:
|
|
self.calls.append("stop")
|
|
|
|
|
|
def _bare_runner(*, seconds: int, running: bool = True) -> GatewayRunner:
|
|
runner = object.__new__(GatewayRunner)
|
|
runner.config = GatewayConfig(systemd_watchdog_seconds=seconds)
|
|
runner._running = running
|
|
runner._systemd_watchdog = None
|
|
return runner
|
|
|
|
|
|
def test_runner_starts_watchdog_only_after_running(monkeypatch):
|
|
_FakeWatchdog.instances.clear()
|
|
monkeypatch.setattr("gateway.systemd_notify.SystemdWatchdog", _FakeWatchdog)
|
|
runner = _bare_runner(seconds=120, running=True)
|
|
|
|
assert runner._start_systemd_watchdog() is True
|
|
|
|
watchdog = _FakeWatchdog.instances[-1]
|
|
assert watchdog.config_enabled is True
|
|
assert watchdog.calls == ["start", "ready:Hermes Gateway running"]
|
|
|
|
|