mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
53 lines
1.7 KiB
Python
53 lines
1.7 KiB
Python
"""Tests for SSL certificate auto-detection in gateway/run.py."""
|
|
|
|
import os
|
|
from unittest.mock import patch, MagicMock
|
|
|
|
|
|
def _load_ensure_ssl():
|
|
"""Import _ensure_ssl_certs fresh (gateway/run.py has heavy deps, so we
|
|
extract just the function source to avoid importing the whole gateway)."""
|
|
# We can test via the actual module since conftest isolates HERMES_HOME,
|
|
# but we need to be careful about side effects. Instead, replicate the
|
|
# logic in a controlled way.
|
|
from types import ModuleType
|
|
import textwrap, ssl as _ssl # noqa: F401
|
|
|
|
code = textwrap.dedent("""\
|
|
import os, ssl
|
|
|
|
def _ensure_ssl_certs():
|
|
if "SSL_CERT_FILE" in os.environ:
|
|
return
|
|
paths = ssl.get_default_verify_paths()
|
|
for candidate in (paths.cafile, paths.openssl_cafile):
|
|
if candidate and os.path.exists(candidate):
|
|
os.environ["SSL_CERT_FILE"] = candidate
|
|
return
|
|
try:
|
|
import certifi
|
|
os.environ["SSL_CERT_FILE"] = certifi.where()
|
|
return
|
|
except ImportError:
|
|
pass
|
|
for candidate in (
|
|
"/etc/ssl/certs/ca-certificates.crt",
|
|
"/etc/ssl/cert.pem",
|
|
):
|
|
if os.path.exists(candidate):
|
|
os.environ["SSL_CERT_FILE"] = candidate
|
|
return
|
|
""")
|
|
mod = ModuleType("_ssl_helper")
|
|
exec(code, mod.__dict__)
|
|
return mod._ensure_ssl_certs
|
|
|
|
|
|
class TestEnsureSslCerts:
|
|
def test_respects_existing_env_var(self):
|
|
fn = _load_ensure_ssl()
|
|
with patch.dict(os.environ, {"SSL_CERT_FILE": "/custom/ca.pem"}):
|
|
fn()
|
|
assert os.environ["SSL_CERT_FILE"] == "/custom/ca.pem"
|
|
|
|
|