mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
93 lines
3.4 KiB
Python
93 lines
3.4 KiB
Python
"""
|
|
Tests for the connect-time user-token (vs bot-token) nudge.
|
|
|
|
``auth.test`` returns the ``user_id`` of whatever principal owns the configured
|
|
token. A real bot token (``xoxb-…``) resolves to the app's bot user and the
|
|
response carries a ``bot_id``; a user/legacy token (``xoxp-…``) resolves to the
|
|
installing *human's* member ID with **no** ``bot_id``. In the latter case the
|
|
adapter binds its identity to a human's member ID, so that person's ``<@…>``
|
|
mentions are misrouted as mentions of the bot. ``_warn_if_not_bot_token``
|
|
detects the missing ``bot_id`` at connect time — the only point where this is
|
|
observable, since a user token still sends/receives without any runtime error —
|
|
and logs an actionable, warning-only nudge.
|
|
"""
|
|
|
|
import logging
|
|
import sys
|
|
from unittest.mock import MagicMock
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Mock slack-bolt if not installed (same pattern as test_slack_mention.py)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def _ensure_slack_mock():
|
|
if "slack_bolt" in sys.modules and hasattr(sys.modules["slack_bolt"], "__file__"):
|
|
return
|
|
|
|
slack_bolt = MagicMock()
|
|
slack_bolt.async_app.AsyncApp = MagicMock
|
|
slack_bolt.adapter.socket_mode.async_handler.AsyncSocketModeHandler = MagicMock
|
|
|
|
slack_sdk = MagicMock()
|
|
slack_sdk.web.async_client.AsyncWebClient = MagicMock
|
|
|
|
for name, mod in [
|
|
("slack_bolt", slack_bolt),
|
|
("slack_bolt.async_app", slack_bolt.async_app),
|
|
("slack_bolt.adapter", slack_bolt.adapter),
|
|
("slack_bolt.adapter.socket_mode", slack_bolt.adapter.socket_mode),
|
|
("slack_bolt.adapter.socket_mode.async_handler",
|
|
slack_bolt.adapter.socket_mode.async_handler),
|
|
("slack_sdk", slack_sdk),
|
|
("slack_sdk.web", slack_sdk.web),
|
|
("slack_sdk.web.async_client", slack_sdk.web.async_client),
|
|
]:
|
|
sys.modules.setdefault(name, mod)
|
|
|
|
|
|
_ensure_slack_mock()
|
|
|
|
import plugins.platforms.slack.adapter as _slack_mod # noqa: E402
|
|
_slack_mod.SLACK_AVAILABLE = True
|
|
|
|
from plugins.platforms.slack.adapter import SlackAdapter # noqa: E402
|
|
|
|
|
|
class _DictAuthResponse(dict):
|
|
"""Mimics slack_sdk's AsyncSlackResponse — dict-like with .get(), like the
|
|
real object the adapter already calls ``.get()`` on in ``connect``."""
|
|
|
|
|
|
class _AttrAuthResponse:
|
|
"""A response shape that is NOT dict-like; values live on ``.data``."""
|
|
|
|
def __init__(self, data):
|
|
self.data = data
|
|
|
|
|
|
def _make_adapter():
|
|
# object.__new__ skips __init__ (heavy setup) — established slack-test pattern.
|
|
return object.__new__(SlackAdapter)
|
|
|
|
|
|
def test_warns_when_bot_id_absent(caplog):
|
|
# User token: auth.test resolves a human member but carries no bot_id.
|
|
adapter = _make_adapter()
|
|
resp = _DictAuthResponse(team_id="T1", user_id="U_HUMAN", user="trevor")
|
|
with caplog.at_level(logging.WARNING):
|
|
adapter._warn_if_not_bot_token(resp, "Acme")
|
|
matched = [r for r in caplog.records
|
|
if "authenticated as a USER" in r.message and "U_HUMAN" in r.message]
|
|
assert matched
|
|
|
|
|
|
def test_no_warning_when_bot_id_present(caplog):
|
|
# Real bot token: auth.test carries a bot_id.
|
|
adapter = _make_adapter()
|
|
resp = _DictAuthResponse(team_id="T1", user_id="U_BOT", bot_id="B123", user="hermes")
|
|
with caplog.at_level(logging.WARNING):
|
|
adapter._warn_if_not_bot_token(resp, "Acme")
|
|
assert not any("authenticated as a USER" in r.message for r in caplog.records)
|
|
|
|
|