mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
115 lines
4 KiB
Python
115 lines
4 KiB
Python
"""Regression: Slack send() must surface retryable + retry_after on 429.
|
|
|
|
The Telegram adapter (PR #46762) extracts retry_after from FloodWait errors
|
|
and sets retryable=True so the base _send_with_retry() layer can honor the
|
|
server-requested backoff. Slack's send() caught all exceptions and returned
|
|
a bare SendResult(success=False) with retryable=False — so 429 rate-limit
|
|
errors were never retried and remaining message chunks were silently dropped.
|
|
|
|
These tests verify the Slack adapter now:
|
|
1. Sets retryable=True for 429 / 500+ / connection errors
|
|
2. Extracts the Retry-After header when present
|
|
3. Leaves non-retryable errors (403, 404, etc.) unchanged
|
|
"""
|
|
|
|
import sys
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
|
|
from gateway.config import PlatformConfig
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Ensure slack mocks are in place before importing the adapter
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def _ensure_slack_mock():
|
|
if "slack_bolt" in sys.modules and hasattr(sys.modules["slack_bolt"], "__file__"):
|
|
return
|
|
slack_bolt = MagicMock()
|
|
slack_bolt.async_app.AsyncApp = MagicMock
|
|
slack_bolt.adapter.socket_mode.async_handler.AsyncSocketModeHandler = MagicMock
|
|
slack_sdk = MagicMock()
|
|
slack_sdk.web.async_client.AsyncWebClient = MagicMock
|
|
for name, mod in [
|
|
("slack_bolt", slack_bolt),
|
|
("slack_bolt.async_app", slack_bolt.async_app),
|
|
("slack_bolt.adapter", slack_bolt.adapter),
|
|
("slack_bolt.adapter.socket_mode", slack_bolt.adapter.socket_mode),
|
|
("slack_bolt.adapter.socket_mode.async_handler", slack_bolt.adapter.socket_mode.async_handler),
|
|
("slack_sdk", slack_sdk),
|
|
("slack_sdk.web", slack_sdk.web),
|
|
("slack_sdk.web.async_client", slack_sdk.web.async_client),
|
|
]:
|
|
sys.modules.setdefault(name, mod)
|
|
|
|
|
|
_ensure_slack_mock()
|
|
|
|
from plugins.platforms.slack.adapter import SlackAdapter
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Helpers
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def _make_adapter():
|
|
config = PlatformConfig(enabled=True, token="xoxb-fake")
|
|
a = SlackAdapter(config)
|
|
a._app = MagicMock()
|
|
a._bot_user_id = "U_BOT"
|
|
a._running = True
|
|
return a
|
|
|
|
|
|
def _slack_api_error(status_code: int, retry_after: str = None):
|
|
"""Simulate a SlackApiError with response status and optional Retry-After."""
|
|
headers = {}
|
|
if retry_after is not None:
|
|
headers["Retry-After"] = retry_after
|
|
resp = SimpleNamespace(
|
|
status_code=status_code,
|
|
headers=headers,
|
|
)
|
|
exc = Exception(f"The request to the Slack API failed. (status: {status_code})")
|
|
exc.response = resp
|
|
return exc
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestSlackSendRetryable:
|
|
@pytest.mark.asyncio
|
|
async def test_429_returns_retryable_with_retry_after(self):
|
|
adapter = _make_adapter()
|
|
client = AsyncMock()
|
|
client.chat_postMessage = AsyncMock(
|
|
side_effect=_slack_api_error(429, retry_after="30")
|
|
)
|
|
adapter._get_client = lambda cid, team_id="": client
|
|
|
|
result = await adapter.send("C123", "hello")
|
|
assert not result.success
|
|
assert result.retryable is True
|
|
assert result.retry_after == 30.0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_500_is_retryable_no_retry_after(self):
|
|
adapter = _make_adapter()
|
|
client = AsyncMock()
|
|
client.chat_postMessage = AsyncMock(
|
|
side_effect=_slack_api_error(500)
|
|
)
|
|
adapter._get_client = lambda cid, team_id="": client
|
|
|
|
result = await adapter.send("C123", "hello")
|
|
assert not result.success
|
|
assert result.retryable is True
|
|
assert result.retry_after is None
|
|
|
|
|