mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
69 lines
2.5 KiB
Python
69 lines
2.5 KiB
Python
import pytest
|
|
from unittest.mock import AsyncMock
|
|
|
|
from gateway.config import GatewayConfig, Platform, PlatformConfig
|
|
from gateway.platforms.base import MessageEvent, MessageType, SendResult
|
|
from gateway.run import (
|
|
GatewayRunner,
|
|
_is_slack_ignored_channel,
|
|
_slack_ignored_channels_from_gateway_config,
|
|
)
|
|
from gateway.session import SessionSource
|
|
|
|
|
|
def _config_with_slack_extra(extra=None):
|
|
return GatewayConfig(
|
|
platforms={
|
|
Platform.SLACK: PlatformConfig(enabled=True, extra=extra or {}),
|
|
}
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_runner_drops_slack_ignored_channel_before_auth_hooks_and_sessions(monkeypatch):
|
|
runner = object.__new__(GatewayRunner)
|
|
runner.config = _config_with_slack_extra({"ignored_channels": "C_PRD"})
|
|
runner._startup_restore_in_progress = False
|
|
|
|
# If the guard regresses, _handle_message will proceed into hooks/auth/session
|
|
# setup and one of these sentinels will fail the test.
|
|
runner.session_store = object()
|
|
monkeypatch.setattr(
|
|
"hermes_cli.plugins.invoke_hook",
|
|
lambda *args, **kwargs: (_ for _ in ()).throw(AssertionError("hook should not run")),
|
|
)
|
|
runner._is_user_authorized = lambda source: (_ for _ in ()).throw(AssertionError("auth should not run"))
|
|
|
|
event = MessageEvent(
|
|
text="<@U_BOT> review this PRD",
|
|
message_type=MessageType.TEXT,
|
|
source=SessionSource(
|
|
platform=Platform.SLACK,
|
|
user_id="U_USER",
|
|
user_name="shubham",
|
|
chat_id="C_PRD",
|
|
chat_type="group",
|
|
),
|
|
)
|
|
|
|
assert await runner._handle_message(event) is None
|
|
|
|
|
|
def test_slack_ignored_channels_env_bridge_fallback(monkeypatch):
|
|
"""SLACK_IGNORED_CHANNELS (set by the plugin's YAML→env bridge) is
|
|
honored when PlatformConfig.extra carries no ignored_channels (#46925)."""
|
|
monkeypatch.setenv("SLACK_IGNORED_CHANNELS", "C_ENV1, C_ENV2")
|
|
config = _config_with_slack_extra({})
|
|
|
|
assert _slack_ignored_channels_from_gateway_config(config) == {"C_ENV1", "C_ENV2"}
|
|
assert _is_slack_ignored_channel(config, "C_ENV1")
|
|
assert not _is_slack_ignored_channel(config, "C_OTHER")
|
|
|
|
|
|
def test_slack_ignored_channels_extra_wins_over_env(monkeypatch):
|
|
"""Explicit PlatformConfig.extra config takes precedence over the env
|
|
bridge fallback."""
|
|
monkeypatch.setenv("SLACK_IGNORED_CHANNELS", "C_ENV")
|
|
config = _config_with_slack_extra({"ignored_channels": ["C_CFG"]})
|
|
|
|
assert _slack_ignored_channels_from_gateway_config(config) == {"C_CFG"}
|