mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
112 lines
4.3 KiB
Python
112 lines
4.3 KiB
Python
"""
|
|
Tests for the Slack ``cron_continuable_surface`` extra key and its pairing warning.
|
|
|
|
``cron_continuable_surface: in_channel`` (paired with ``reply_in_thread: false``)
|
|
lets a continuable cron job deliver FLAT into a channel — no dedicated thread —
|
|
so a plain channel reply continues the job via the shared-channel session
|
|
``(slack, channel_id, None)``. See specs/cron-inchannel-continuable decisions
|
|
D1/D4/D5/D6.
|
|
|
|
- ``_cron_continuable_surface`` resolves the key: default ``"thread"``, coerces
|
|
any unrecognised value to ``"thread"`` (fail safe), only ``"in_channel"``
|
|
opts in.
|
|
- ``supports_inchannel_continuable`` is True on Slack (it has both a flat-reply
|
|
outbound gate and a whole-channel inbound session bucket).
|
|
- ``_warn_if_inchannel_without_flat_reply`` warns (D5: warn, not hard-require)
|
|
when ``in_channel`` is set without ``reply_in_thread: false`` — the misconfig
|
|
fails SAFE to a threaded continuation, so it is a warning, not a rejection.
|
|
"""
|
|
|
|
import logging
|
|
import sys
|
|
from unittest.mock import MagicMock
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Mock slack-bolt if not installed (same pattern as test_slack_user_token_warning.py)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def _ensure_slack_mock():
|
|
if "slack_bolt" in sys.modules and hasattr(sys.modules["slack_bolt"], "__file__"):
|
|
return
|
|
|
|
slack_bolt = MagicMock()
|
|
slack_bolt.async_app.AsyncApp = MagicMock
|
|
slack_bolt.adapter.socket_mode.async_handler.AsyncSocketModeHandler = MagicMock
|
|
|
|
slack_sdk = MagicMock()
|
|
slack_sdk.web.async_client.AsyncWebClient = MagicMock
|
|
|
|
for name, mod in [
|
|
("slack_bolt", slack_bolt),
|
|
("slack_bolt.async_app", slack_bolt.async_app),
|
|
("slack_bolt.adapter", slack_bolt.adapter),
|
|
("slack_bolt.adapter.socket_mode", slack_bolt.adapter.socket_mode),
|
|
("slack_bolt.adapter.socket_mode.async_handler",
|
|
slack_bolt.adapter.socket_mode.async_handler),
|
|
("slack_sdk", slack_sdk),
|
|
("slack_sdk.web", slack_sdk.web),
|
|
("slack_sdk.web.async_client", slack_sdk.web.async_client),
|
|
]:
|
|
sys.modules.setdefault(name, mod)
|
|
|
|
|
|
_ensure_slack_mock()
|
|
|
|
import plugins.platforms.slack.adapter as _slack_mod # noqa: E402
|
|
_slack_mod.SLACK_AVAILABLE = True
|
|
|
|
from plugins.platforms.slack.adapter import SlackAdapter # noqa: E402
|
|
|
|
|
|
def _make_adapter(extra):
|
|
"""object.__new__ skips __init__ (heavy setup) — established slack-test
|
|
pattern. Attach a minimal config carrying only the ``extra`` dict."""
|
|
adapter = object.__new__(SlackAdapter)
|
|
cfg = MagicMock()
|
|
cfg.extra = dict(extra)
|
|
adapter.config = cfg
|
|
return adapter
|
|
|
|
|
|
# --- capability flag -------------------------------------------------------
|
|
|
|
def test_slack_declares_inchannel_capability():
|
|
"""Slack has both halves the in_channel surface needs, so the class-level
|
|
capability flag the cron scheduler reads generically must be True."""
|
|
assert SlackAdapter.supports_inchannel_continuable is True
|
|
|
|
|
|
# --- surface resolver ------------------------------------------------------
|
|
|
|
|
|
def test_surface_unrecognised_value_coerces_to_thread():
|
|
"""Fail safe: any value that isn't 'in_channel' resolves to 'thread'."""
|
|
adapter = _make_adapter({"cron_continuable_surface": "bogus"})
|
|
assert adapter._cron_continuable_surface() == "thread"
|
|
|
|
|
|
# --- pairing warning (D5: warn, not hard-require) --------------------------
|
|
|
|
def test_warns_when_in_channel_without_flat_reply(caplog):
|
|
"""in_channel set, reply_in_thread left at its True default → warn."""
|
|
adapter = _make_adapter({"cron_continuable_surface": "in_channel"})
|
|
with caplog.at_level(logging.WARNING):
|
|
adapter._warn_if_inchannel_without_flat_reply("Acme")
|
|
matched = [r for r in caplog.records
|
|
if "cron_continuable_surface=in_channel" in r.message
|
|
and "reply_in_thread=false" in r.message]
|
|
assert matched
|
|
|
|
|
|
def test_no_warning_when_properly_paired(caplog):
|
|
"""in_channel + reply_in_thread: false is the correct pairing → silent."""
|
|
adapter = _make_adapter(
|
|
{"cron_continuable_surface": "in_channel", "reply_in_thread": False}
|
|
)
|
|
with caplog.at_level(logging.WARNING):
|
|
adapter._warn_if_inchannel_without_flat_reply("Acme")
|
|
assert not any("cron_continuable_surface=in_channel" in r.message
|
|
for r in caplog.records)
|
|
|
|
|