mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
74 lines
2.1 KiB
Python
74 lines
2.1 KiB
Python
"""Regression guard for Slack bot/workflow-sender authorization bypass.
|
|
|
|
Mirrors tests/gateway/test_feishu_bot_auth_bypass.py for Platform.SLACK.
|
|
|
|
Slack Workflow Builder posts (and other app/bot messages) arrive as
|
|
``subtype=bot_message`` with ``user=None``, so the SessionSource carries
|
|
``is_bot=True`` and ``user_id=None``. Without the #4466 bot bypass running
|
|
*before* the no-user-id guard, these senders are rejected at
|
|
``_is_user_authorized`` even when the operator enabled ``SLACK_ALLOW_BOTS`` --
|
|
the bug that makes @mentioning the bot from a Slack workflow do nothing.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
from gateway.session import Platform, SessionSource
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _isolate_slack_env(monkeypatch):
|
|
for var in (
|
|
"SLACK_ALLOW_BOTS",
|
|
"SLACK_ALLOWED_USERS",
|
|
"SLACK_ALLOW_ALL_USERS",
|
|
"GATEWAY_ALLOW_ALL_USERS",
|
|
"GATEWAY_ALLOWED_USERS",
|
|
):
|
|
monkeypatch.delenv(var, raising=False)
|
|
|
|
|
|
def _make_bare_runner():
|
|
from gateway.run import GatewayRunner
|
|
|
|
runner = object.__new__(GatewayRunner)
|
|
runner.pairing_store = SimpleNamespace(is_approved=lambda *_a, **_kw: False)
|
|
return runner
|
|
|
|
|
|
def _make_slack_bot_source():
|
|
# Workflow Builder / app posts: subtype=bot_message, user=None.
|
|
return SessionSource(
|
|
platform=Platform.SLACK,
|
|
chat_id="C0123",
|
|
chat_type="group",
|
|
user_id=None,
|
|
user_name="",
|
|
is_bot=True,
|
|
)
|
|
|
|
|
|
def _make_slack_human_source(user_id="U_human"):
|
|
return SessionSource(
|
|
platform=Platform.SLACK,
|
|
chat_id="C0123",
|
|
chat_type="group",
|
|
user_id=user_id,
|
|
user_name="Human",
|
|
is_bot=False,
|
|
)
|
|
|
|
|
|
def test_slack_bot_authorized_when_allow_bots_all(monkeypatch):
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("SLACK_ALLOW_BOTS", "all")
|
|
assert runner._is_user_authorized(_make_slack_bot_source()) is True
|
|
|
|
|
|
def test_slack_human_unaffected_by_bot_bypass(monkeypatch):
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("SLACK_ALLOW_ALL_USERS", "true")
|
|
assert runner._is_user_authorized(_make_slack_human_source()) is True
|