mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
134 lines
4 KiB
Python
134 lines
4 KiB
Python
"""Tests for gateway/shutdown_flush.py — pending message durability (#72680)."""
|
|
|
|
import json
|
|
import os
|
|
import stat
|
|
import time
|
|
from pathlib import Path
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
|
|
from gateway.shutdown_flush import (
|
|
_serialise_value,
|
|
flush_pending_to_file,
|
|
recover_pending_to_db,
|
|
)
|
|
|
|
|
|
def _make_flush_dir(tmp_path: Path) -> Path:
|
|
"""Create a temp flush dir and monkeypatch _get_flush_dir to use it."""
|
|
flush_dir = tmp_path / "pending_messages"
|
|
flush_dir.mkdir(parents=True, exist_ok=True)
|
|
return flush_dir
|
|
|
|
|
|
def test_flush_writes_string_pending_to_file(tmp_path, monkeypatch):
|
|
flush_dir = _make_flush_dir(tmp_path)
|
|
monkeypatch.setattr(
|
|
"gateway.shutdown_flush._get_flush_dir", lambda: flush_dir
|
|
)
|
|
pending = {"agent:main:telegram:supergroup:123": "hello world"}
|
|
count = flush_pending_to_file(pending, reason="shutdown")
|
|
assert count == 1
|
|
files = list(flush_dir.glob("*.json"))
|
|
assert len(files) == 1
|
|
payload = json.loads(files[0].read_text(encoding="utf-8"))
|
|
assert payload["session_key"] == "agent:main:telegram:supergroup:123"
|
|
assert payload["reason"] == "shutdown"
|
|
assert payload["data"]["text"] == "hello world"
|
|
assert ":" not in files[0].name
|
|
assert "telegram" not in files[0].name
|
|
|
|
|
|
def test_flush_writes_message_event_to_file(tmp_path, monkeypatch):
|
|
flush_dir = _make_flush_dir(tmp_path)
|
|
monkeypatch.setattr(
|
|
"gateway.shutdown_flush._get_flush_dir", lambda: flush_dir
|
|
)
|
|
event = MagicMock()
|
|
event.text = "user message"
|
|
event.session_id = "20260728_120000_abc"
|
|
event.platform = "telegram"
|
|
event.sender_id = "456"
|
|
event.sender_name = "Alice"
|
|
event.reply_to = None
|
|
event.media = None
|
|
event.raw_event = None
|
|
|
|
count = flush_pending_to_file({"session_key_1": event}, reason="adapter_shutdown")
|
|
assert count == 1
|
|
files = list(flush_dir.glob("*.json"))
|
|
assert len(files) == 1
|
|
payload = json.loads(files[0].read_text(encoding="utf-8"))
|
|
assert payload["data"]["text"] == "user message"
|
|
assert payload["data"]["session_id"] == "20260728_120000_abc"
|
|
|
|
|
|
def test_recover_inserts_via_append_message_and_deletes_file(tmp_path, monkeypatch):
|
|
flush_dir = _make_flush_dir(tmp_path)
|
|
monkeypatch.setattr(
|
|
"gateway.shutdown_flush._get_flush_dir", lambda: flush_dir
|
|
)
|
|
ts = int(time.time())
|
|
# Write a flush file with session_id
|
|
payload = {
|
|
"session_key": "agent:main:telegram:supergroup:123",
|
|
"reason": "shutdown",
|
|
"ts": ts,
|
|
"data": {
|
|
"text": "lost message",
|
|
"session_id": "20260728_120000_abc",
|
|
},
|
|
}
|
|
flush_file = flush_dir / "test_session_123.json"
|
|
flush_file.write_text(json.dumps(payload), encoding="utf-8")
|
|
|
|
mock_db = MagicMock()
|
|
count = recover_pending_to_db(mock_db)
|
|
|
|
assert count == 1
|
|
mock_db.append_message.assert_called_once_with(
|
|
session_id="20260728_120000_abc",
|
|
role="user",
|
|
content="lost message",
|
|
timestamp=ts,
|
|
)
|
|
assert not flush_file.exists()
|
|
|
|
|
|
def test_serialise_object_with_text():
|
|
obj = MagicMock()
|
|
obj.text = "msg"
|
|
obj.session_id = "sid"
|
|
obj.platform = None
|
|
obj.sender_id = None
|
|
obj.sender_name = None
|
|
obj.reply_to = None
|
|
obj.media = None
|
|
obj.raw_event = None
|
|
result = _serialise_value(obj)
|
|
assert result is not None
|
|
assert result["text"] == "msg"
|
|
assert result["session_id"] == "sid"
|
|
|
|
|
|
def test_get_flush_dir_uses_get_hermes_home(tmp_path, monkeypatch):
|
|
"""Flush dir must use get_hermes_home(), not hardcoded Path.home()."""
|
|
import gateway.shutdown_flush as mod
|
|
|
|
captured = {}
|
|
|
|
def fake_get_hermes_home():
|
|
from pathlib import Path
|
|
captured["called"] = True
|
|
return tmp_path
|
|
|
|
monkeypatch.setattr(
|
|
"hermes_constants.get_hermes_home", fake_get_hermes_home
|
|
)
|
|
result = mod._get_flush_dir()
|
|
assert captured.get("called") is True
|
|
assert result == tmp_path / "pending_messages"
|
|
|
|
|