mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
104 lines
4.2 KiB
Python
104 lines
4.2 KiB
Python
"""Tests for GatewayRunner._format_session_info — session config surfacing."""
|
|
|
|
import pytest
|
|
from unittest.mock import patch
|
|
|
|
from gateway.run import GatewayRunner
|
|
|
|
|
|
@pytest.fixture()
|
|
def runner():
|
|
"""Create a bare GatewayRunner without __init__."""
|
|
return GatewayRunner.__new__(GatewayRunner)
|
|
|
|
|
|
def _patch_info(tmp_path, config_yaml, model, runtime):
|
|
"""Return a context-manager stack that patches _format_session_info deps."""
|
|
cfg_path = tmp_path / "config.yaml"
|
|
if config_yaml is not None:
|
|
cfg_path.write_text(config_yaml)
|
|
return (
|
|
patch("gateway.run._hermes_home", tmp_path),
|
|
patch("gateway.run._resolve_gateway_model", return_value=model),
|
|
patch("gateway.run._resolve_runtime_agent_kwargs", return_value=runtime),
|
|
)
|
|
|
|
|
|
class TestFormatSessionInfo:
|
|
|
|
def test_includes_model_name(self, runner, tmp_path):
|
|
p1, p2, p3 = _patch_info(tmp_path, "model:\n default: anthropic/claude-opus-4.6\n provider: openrouter\n",
|
|
"anthropic/claude-opus-4.6",
|
|
{"provider": "openrouter", "base_url": "https://openrouter.ai/api/v1", "api_key": "k"})
|
|
with p1, p2, p3:
|
|
info = runner._format_session_info()
|
|
assert "claude-opus-4.6" in info
|
|
|
|
|
|
def test_config_context_length(self, runner, tmp_path):
|
|
p1, p2, p3 = _patch_info(tmp_path, "model:\n default: test-model\n context_length: 32768\n",
|
|
"test-model",
|
|
{"provider": "custom", "base_url": "", "api_key": ""})
|
|
with p1, p2, p3:
|
|
info = runner._format_session_info()
|
|
assert "32K" in info
|
|
assert "config" in info
|
|
|
|
def test_default_fallback_hint(self, runner, tmp_path):
|
|
p1, p2, p3 = _patch_info(tmp_path, "model:\n default: unknown-model-xyz\n",
|
|
"unknown-model-xyz",
|
|
{"provider": "", "base_url": "", "api_key": ""})
|
|
with p1, p2, p3:
|
|
info = runner._format_session_info()
|
|
assert "256K" in info
|
|
assert "model.context_length" in info
|
|
|
|
def test_local_endpoint_shown(self, runner, tmp_path):
|
|
p1, p2, p3 = _patch_info(
|
|
tmp_path,
|
|
"model:\n default: qwen3:8b\n provider: custom\n base_url: http://localhost:11434/v1\n context_length: 8192\n",
|
|
"qwen3:8b",
|
|
{"provider": "custom", "base_url": "http://localhost:11434/v1", "api_key": ""})
|
|
with p1, p2, p3:
|
|
info = runner._format_session_info()
|
|
assert "localhost:11434" in info
|
|
assert "8K" in info
|
|
|
|
|
|
class TestResetNoticeSessionInfo:
|
|
"""#59003: the auto-reset banner must report the serving profile's config,
|
|
not the multiplexer's base config."""
|
|
|
|
_RUNTIME = {"provider": "", "base_url": "", "api_key": ""}
|
|
|
|
def _source(self):
|
|
from gateway.config import Platform
|
|
from gateway.session import SessionSource
|
|
return SessionSource(
|
|
platform=Platform.TELEGRAM, chat_id="123", user_id="u1",
|
|
profile="planner",
|
|
)
|
|
|
|
def _homes(self, tmp_path):
|
|
base = tmp_path / "base"
|
|
profile = tmp_path / "profiles" / "planner"
|
|
profile.mkdir(parents=True)
|
|
base.mkdir()
|
|
base.joinpath("config.yaml").write_text(
|
|
"model:\n default: base-model\n provider: custom\n context_length: 1000\n")
|
|
profile.joinpath("config.yaml").write_text(
|
|
"model:\n default: profile-model\n provider: anthropic\n context_length: 2000\n")
|
|
return base, profile
|
|
|
|
def test_multiplex_uses_profile_config(self, runner, tmp_path):
|
|
from types import SimpleNamespace
|
|
base, profile = self._homes(tmp_path)
|
|
runner.config = SimpleNamespace(multiplex_profiles=True)
|
|
with patch("gateway.run._hermes_home", base), \
|
|
patch.object(GatewayRunner, "_resolve_profile_home_for_source", return_value=profile), \
|
|
patch("gateway.run._resolve_runtime_agent_kwargs", return_value=self._RUNTIME):
|
|
info = runner._reset_notice_session_info(self._source())
|
|
assert "profile-model" in info
|
|
assert "anthropic" in info
|
|
assert "base-model" not in info
|
|
|