mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
135 lines
4 KiB
Python
135 lines
4 KiB
Python
"""Unit tests for gateway.runtime_footer — the opt-in runtime-metadata footer
|
|
appended to final gateway replies."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
|
|
import pytest
|
|
|
|
from gateway.runtime_footer import (
|
|
_home_relative_cwd,
|
|
_model_short,
|
|
build_footer_line,
|
|
format_runtime_footer,
|
|
resolve_footer_config,
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _model_short + _home_relative_cwd
|
|
# ---------------------------------------------------------------------------
|
|
|
|
@pytest.mark.parametrize(
|
|
"model,expected",
|
|
[
|
|
("openai/gpt-5.4", "gpt-5.4"),
|
|
("anthropic/claude-sonnet-4.6", "claude-sonnet-4.6"),
|
|
("gpt-5.4", "gpt-5.4"),
|
|
("", ""),
|
|
(None, ""),
|
|
],
|
|
)
|
|
def test_model_short_drops_vendor_prefix(model, expected):
|
|
assert _model_short(model) == expected
|
|
|
|
|
|
def test_home_relative_cwd_collapses_home(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("HOME", str(tmp_path))
|
|
sub = tmp_path / "projects" / "hermes"
|
|
sub.mkdir(parents=True)
|
|
result = _home_relative_cwd(str(sub))
|
|
assert result == "~/projects/hermes"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# format_runtime_footer
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def test_format_footer_all_fields(monkeypatch, tmp_path):
|
|
monkeypatch.setenv("HOME", str(tmp_path))
|
|
monkeypatch.setenv("TERMINAL_CWD", str(tmp_path / "projects" / "hermes"))
|
|
(tmp_path / "projects" / "hermes").mkdir(parents=True)
|
|
out = format_runtime_footer(
|
|
model="openrouter/openai/gpt-5.4",
|
|
context_tokens=68000,
|
|
context_length=100000,
|
|
cwd=None, # falls back to TERMINAL_CWD env var
|
|
fields=("model", "context_pct", "cwd"),
|
|
)
|
|
assert out == "gpt-5.4 · 68% · ~/projects/hermes"
|
|
|
|
|
|
def test_format_footer_skips_missing_context_length():
|
|
out = format_runtime_footer(
|
|
model="openai/gpt-5.4",
|
|
context_tokens=500,
|
|
context_length=None,
|
|
cwd="/tmp/wd",
|
|
fields=("model", "context_pct", "cwd"),
|
|
)
|
|
# context_pct dropped silently; no "?%" artifact
|
|
assert "%" not in out
|
|
assert "gpt-5.4" in out
|
|
assert "/tmp/wd" in out
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# resolve_footer_config
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_resolve_platform_override_wins():
|
|
user = {
|
|
"display": {
|
|
"runtime_footer": {"enabled": True, "fields": ["model"]},
|
|
"platforms": {
|
|
"slack": {"runtime_footer": {"enabled": False}},
|
|
},
|
|
},
|
|
}
|
|
# Telegram picks up the global enable
|
|
assert resolve_footer_config(user, "telegram")["enabled"] is True
|
|
# Slack overrides to off
|
|
assert resolve_footer_config(user, "slack")["enabled"] is False
|
|
|
|
|
|
def test_resolve_platform_can_add_fields_only():
|
|
user = {
|
|
"display": {
|
|
"runtime_footer": {"enabled": True},
|
|
"platforms": {
|
|
"discord": {"runtime_footer": {"fields": ["context_pct"]}},
|
|
},
|
|
},
|
|
}
|
|
tg = resolve_footer_config(user, "telegram")
|
|
assert tg["enabled"] is True
|
|
assert tg["fields"] == ["model", "context_pct", "cwd"]
|
|
dc = resolve_footer_config(user, "discord")
|
|
assert dc["enabled"] is True
|
|
assert dc["fields"] == ["context_pct"]
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# build_footer_line — top-level entry point used by gateway/run.py
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_build_footer_per_platform_off_suppresses():
|
|
user = {
|
|
"display": {
|
|
"runtime_footer": {"enabled": True},
|
|
"platforms": {"slack": {"runtime_footer": {"enabled": False}}},
|
|
},
|
|
}
|
|
out = build_footer_line(
|
|
user_config=user,
|
|
platform_key="slack",
|
|
model="openai/gpt-5.4",
|
|
context_tokens=10, context_length=100,
|
|
cwd="/tmp",
|
|
)
|
|
assert out == ""
|
|
|
|
|