mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
46 lines
1.5 KiB
Python
46 lines
1.5 KiB
Python
"""Regression test: /retry must return the agent response, not None.
|
|
|
|
Before the fix in PR #441, _handle_retry_command() called
|
|
_handle_message(retry_event) but discarded its return value with `return None`,
|
|
so users never received the final response.
|
|
"""
|
|
import pytest
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
from gateway.run import GatewayRunner
|
|
from gateway.platforms.base import MessageEvent, MessageType
|
|
|
|
|
|
@pytest.fixture
|
|
def gateway(tmp_path):
|
|
config = MagicMock()
|
|
config.sessions_dir = tmp_path
|
|
config.max_context_messages = 20
|
|
gw = GatewayRunner.__new__(GatewayRunner)
|
|
gw.config = config
|
|
gw.session_store = MagicMock()
|
|
return gw
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_retry_returns_response_not_none(gateway):
|
|
"""_handle_retry_command must return the inner handler response, not None."""
|
|
gateway.session_store.get_or_create_session.return_value = MagicMock(
|
|
session_id="test-session"
|
|
)
|
|
gateway.session_store.load_transcript.return_value = [
|
|
{"role": "user", "content": "Hello Hermes"},
|
|
{"role": "assistant", "content": "Hi there!"},
|
|
]
|
|
gateway.session_store.rewrite_transcript = MagicMock()
|
|
expected_response = "Hi there! (retried)"
|
|
gateway._handle_message = AsyncMock(return_value=expected_response)
|
|
event = MessageEvent(
|
|
text="/retry",
|
|
message_type=MessageType.TEXT,
|
|
source=MagicMock(),
|
|
)
|
|
result = await gateway._handle_retry_command(event)
|
|
assert result is not None, "/retry must not return None"
|
|
assert result == expected_response
|
|
|
|
|