mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
108 lines
4.2 KiB
Python
108 lines
4.2 KiB
Python
"""Tests for gateway/profile_routing.py — profile-based routing."""
|
|
|
|
import pytest
|
|
from gateway.profile_routing import (
|
|
ProfileRoute,
|
|
parse_profile_routes,
|
|
match_profile_route,
|
|
)
|
|
|
|
|
|
class TestProfileRoute:
|
|
def test_specificity_thread(self):
|
|
r = ProfileRoute(name="t", platform="discord", profile="p",
|
|
guild_id="g", chat_id="c", thread_id="t")
|
|
assert r.specificity == 14 # 2 + 4 + 8
|
|
|
|
|
|
def test_frozen(self):
|
|
r = ProfileRoute(name="x", platform="discord", profile="p")
|
|
with pytest.raises(AttributeError):
|
|
r.name = "y"
|
|
|
|
|
|
class TestProfileRouteMatching:
|
|
def test_exact_thread_match(self):
|
|
r = ProfileRoute(name="t", platform="discord", profile="trader",
|
|
guild_id="111", chat_id="222", thread_id="333")
|
|
assert r.matches("discord", guild_id="111", chat_id="222", thread_id="333")
|
|
assert not r.matches("discord", guild_id="111", chat_id="222", thread_id="444")
|
|
|
|
|
|
def test_guild_and_chat_are_conjunctive(self):
|
|
# A route declaring BOTH guild_id and chat_id requires both to match.
|
|
# Regression guard: previously chat_id was checked first and returned
|
|
# True before guild_id was ever consulted.
|
|
r = ProfileRoute(name="gc", platform="discord", profile="scoped",
|
|
guild_id="111", chat_id="222")
|
|
# Both match (direct channel) -> match
|
|
assert r.matches("discord", guild_id="111", chat_id="222")
|
|
# Both match via parent (thread inside the channel) -> match
|
|
assert r.matches("discord", guild_id="111", chat_id="333", parent_chat_id="222")
|
|
# chat matches but guild differs -> NO match (the bug this guards)
|
|
assert not r.matches("discord", guild_id="999", chat_id="222")
|
|
# guild matches but chat differs -> NO match
|
|
assert not r.matches("discord", guild_id="111", chat_id="333")
|
|
|
|
|
|
class TestParseProfileRoutes:
|
|
def test_empty(self):
|
|
assert parse_profile_routes(None) == []
|
|
assert parse_profile_routes([]) == []
|
|
|
|
|
|
class TestMatchProfileRoute:
|
|
|
|
|
|
def test_no_match_returns_none(self):
|
|
routes = [
|
|
ProfileRoute(name="r", platform="telegram", profile="p"),
|
|
]
|
|
assert match_profile_route(routes, "discord") is None
|
|
|
|
|
|
class TestSessionKeyIntegration:
|
|
def test_default_profile_key(self):
|
|
from gateway.session import build_session_key, SessionSource, Platform
|
|
src = SessionSource(platform=Platform.DISCORD, chat_id="123",
|
|
chat_type="channel", user_id="456")
|
|
key = build_session_key(src)
|
|
assert key.startswith("agent:main:")
|
|
|
|
|
|
class TestParentChatIdMatching:
|
|
"""Thread messages carry thread_id as chat_id; parent_chat_id is the channel."""
|
|
|
|
def test_channel_route_matches_via_parent_chat_id(self):
|
|
r = ProfileRoute(name="ch", platform="discord", profile="trader",
|
|
chat_id="222")
|
|
assert r.matches("discord", chat_id="333", parent_chat_id="222")
|
|
|
|
|
|
def test_match_profile_route_with_parent_chat_id(self):
|
|
routes = [
|
|
ProfileRoute(name="ch", platform="discord", profile="trader",
|
|
chat_id="222"),
|
|
]
|
|
m = match_profile_route(routes, "discord", chat_id="333", parent_chat_id="222")
|
|
assert m is not None
|
|
assert m.profile == "trader"
|
|
|
|
|
|
class TestForumPostMatching:
|
|
"""Test that forum posts match via parent_chat_id (direct parent)."""
|
|
|
|
|
|
def test_forum_post_comment_matches_channel_not_thread_id(self):
|
|
"""Verify that thread_id matching is distinct from parent_chat_id matching."""
|
|
routes = [
|
|
ProfileRoute(name="forum", platform="discord", profile="forum_profile",
|
|
chat_id="forum_channel_123"),
|
|
ProfileRoute(name="post", platform="discord", profile="post_profile",
|
|
thread_id="post_thread_456"),
|
|
]
|
|
# A comment on the forum post should match the forum channel route, not the thread route
|
|
m = match_profile_route(routes, "discord", chat_id="post_thread_456",
|
|
parent_chat_id="forum_channel_123")
|
|
assert m is not None
|
|
assert m.profile == "forum_profile"
|