mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
59 lines
2.3 KiB
Python
59 lines
2.3 KiB
Python
"""Regression tests for mixed-attachment routing in gateway/run.py.
|
|
|
|
Issue #25935: when a message mixes a real image with a document (e.g. a .md
|
|
brief), Discord types the whole message MessageType.PHOTO. The per-attachment
|
|
loops must classify each attachment by its OWN mimetype:
|
|
|
|
* A document must NOT be swept into image_paths just because the message-level
|
|
type is PHOTO — mislabelling it as an image sent its bytes to the vision
|
|
endpoint, which rejected them with a non-retryable HTTP 400 and killed the
|
|
whole turn ("Could not process image").
|
|
* That same document must STILL reach the agent as a readable cached file via
|
|
the document context-note path, even though the message-level type isn't
|
|
DOCUMENT.
|
|
|
|
The message-level fallback (PHOTO/VOICE/AUDIO/VIDEO) is preserved only for
|
|
attachments whose per-file mimetype is unknown (empty) — platforms that don't
|
|
populate media_types.
|
|
"""
|
|
|
|
from types import SimpleNamespace
|
|
|
|
from gateway.platforms.base import MessageType
|
|
from gateway.run import (
|
|
_build_media_placeholder,
|
|
_event_media_is_audio,
|
|
_event_media_is_image,
|
|
_event_media_is_video,
|
|
)
|
|
|
|
|
|
def _evt(media_urls, media_types, message_type):
|
|
return SimpleNamespace(
|
|
media_urls=media_urls,
|
|
media_types=media_types,
|
|
message_type=message_type,
|
|
)
|
|
|
|
|
|
# ─── per-attachment classification helpers ───────────────────────────────────
|
|
|
|
|
|
def test_image_trusts_own_mime_over_photo_message_type():
|
|
evt = _evt(["/c/pic.png", "/c/brief.md"], ["image/png", "text/markdown"], MessageType.PHOTO)
|
|
assert _event_media_is_image(evt, 0) is True
|
|
# The document must NOT be promoted to an image by the PHOTO fallback.
|
|
assert _event_media_is_image(evt, 1) is False
|
|
|
|
|
|
# ─── _build_media_placeholder ────────────────────────────────────────────────
|
|
|
|
|
|
def test_placeholder_document_in_photo_message_is_not_an_image():
|
|
evt = _evt(["/c/product.png", "/c/brief.md"], ["image/png", "text/markdown"], MessageType.PHOTO)
|
|
out = _build_media_placeholder(evt)
|
|
assert "[User sent an image: /c/product.png]" in out
|
|
assert "[User sent an image: /c/brief.md]" not in out
|
|
assert "[User sent a file: /c/brief.md]" in out
|
|
|
|
|