mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
132 lines
4.8 KiB
Python
132 lines
4.8 KiB
Python
"""Tests for gateway/mirror.py — session mirroring."""
|
|
|
|
import json
|
|
from unittest.mock import patch, MagicMock
|
|
|
|
import gateway.mirror as mirror_mod
|
|
from gateway.mirror import (
|
|
mirror_to_session,
|
|
_find_session_id,
|
|
)
|
|
|
|
|
|
def _setup_sessions(tmp_path, sessions_data):
|
|
"""Helper to write a fake sessions.json and patch module-level paths."""
|
|
sessions_dir = tmp_path / "sessions"
|
|
sessions_dir.mkdir(parents=True, exist_ok=True)
|
|
index_file = sessions_dir / "sessions.json"
|
|
index_file.write_text(json.dumps(sessions_data))
|
|
return sessions_dir, index_file
|
|
|
|
|
|
class TestFindSessionId:
|
|
def test_finds_matching_session(self, tmp_path):
|
|
sessions_dir, index_file = _setup_sessions(tmp_path, {
|
|
"agent:main:telegram:dm": {
|
|
"session_id": "sess_abc",
|
|
"origin": {"platform": "telegram", "chat_id": "12345"},
|
|
"updated_at": "2026-01-01T00:00:00",
|
|
}
|
|
})
|
|
|
|
with patch.object(mirror_mod, "_SESSIONS_DIR", sessions_dir), \
|
|
patch.object(mirror_mod, "_SESSIONS_INDEX", index_file):
|
|
result = _find_session_id("telegram", "12345")
|
|
|
|
assert result == "sess_abc"
|
|
|
|
def test_returns_most_recent(self, tmp_path):
|
|
sessions_dir, index_file = _setup_sessions(tmp_path, {
|
|
"old": {
|
|
"session_id": "sess_old",
|
|
"origin": {"platform": "telegram", "chat_id": "12345"},
|
|
"updated_at": "2026-01-01T00:00:00",
|
|
},
|
|
"new": {
|
|
"session_id": "sess_new",
|
|
"origin": {"platform": "telegram", "chat_id": "12345"},
|
|
"updated_at": "2026-02-01T00:00:00",
|
|
},
|
|
})
|
|
|
|
with patch.object(mirror_mod, "_SESSIONS_DIR", sessions_dir), \
|
|
patch.object(mirror_mod, "_SESSIONS_INDEX", index_file):
|
|
result = _find_session_id("telegram", "12345")
|
|
|
|
assert result == "sess_new"
|
|
|
|
def test_thread_id_disambiguates_same_chat(self, tmp_path):
|
|
sessions_dir, index_file = _setup_sessions(tmp_path, {
|
|
"topic_a": {
|
|
"session_id": "sess_topic_a",
|
|
"origin": {"platform": "telegram", "chat_id": "-1001", "thread_id": "10"},
|
|
"updated_at": "2026-01-01T00:00:00",
|
|
},
|
|
"topic_b": {
|
|
"session_id": "sess_topic_b",
|
|
"origin": {"platform": "telegram", "chat_id": "-1001", "thread_id": "11"},
|
|
"updated_at": "2026-02-01T00:00:00",
|
|
},
|
|
})
|
|
|
|
with patch.object(mirror_mod, "_SESSIONS_DIR", sessions_dir), \
|
|
patch.object(mirror_mod, "_SESSIONS_INDEX", index_file):
|
|
result = _find_session_id("telegram", "-1001", thread_id="10")
|
|
|
|
assert result == "sess_topic_a"
|
|
|
|
|
|
class TestMirrorToSession:
|
|
|
|
|
|
def test_successful_mirror_uses_user_id_for_group_session(self, tmp_path):
|
|
sessions_dir, index_file = _setup_sessions(tmp_path, {
|
|
"alice": {
|
|
"session_id": "sess_alice",
|
|
"origin": {"platform": "telegram", "chat_id": "-1001", "user_id": "alice"},
|
|
"updated_at": "2026-01-01T00:00:00",
|
|
},
|
|
"bob": {
|
|
"session_id": "sess_bob",
|
|
"origin": {"platform": "telegram", "chat_id": "-1001", "user_id": "bob"},
|
|
"updated_at": "2026-02-01T00:00:00",
|
|
},
|
|
})
|
|
|
|
with patch.object(mirror_mod, "_SESSIONS_DIR", sessions_dir), \
|
|
patch.object(mirror_mod, "_SESSIONS_INDEX", index_file), \
|
|
patch("gateway.mirror._append_to_sqlite") as mock_sqlite:
|
|
result = mirror_to_session(
|
|
"telegram",
|
|
"-1001",
|
|
"Hello group!",
|
|
source_label="cli",
|
|
user_id="alice",
|
|
)
|
|
|
|
assert result is True
|
|
mock_sqlite.assert_called_once()
|
|
assert mock_sqlite.call_args[0][0] == "sess_alice"
|
|
|
|
def test_no_matching_session(self, tmp_path):
|
|
sessions_dir, index_file = _setup_sessions(tmp_path, {})
|
|
|
|
with patch.object(mirror_mod, "_SESSIONS_DIR", sessions_dir), \
|
|
patch.object(mirror_mod, "_SESSIONS_INDEX", index_file):
|
|
result = mirror_to_session("telegram", "99999", "Hello!")
|
|
|
|
assert result is False
|
|
|
|
|
|
class TestAppendToSqlite:
|
|
def test_connection_is_closed_after_use(self, tmp_path):
|
|
"""Verify _append_to_sqlite closes the SessionDB connection."""
|
|
from gateway.mirror import _append_to_sqlite
|
|
mock_db = MagicMock()
|
|
|
|
with patch("hermes_state.SessionDB", return_value=mock_db):
|
|
_append_to_sqlite("sess_1", {"role": "assistant", "content": "hello"})
|
|
|
|
mock_db.append_message.assert_called_once()
|
|
mock_db.close.assert_called_once()
|
|
|