mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
69 lines
2.3 KiB
Python
69 lines
2.3 KiB
Python
from datetime import datetime
|
|
from zoneinfo import ZoneInfo
|
|
|
|
from gateway.message_timestamps import (
|
|
coerce_message_timestamp,
|
|
render_user_content_with_timestamp,
|
|
strip_leading_message_timestamps,
|
|
)
|
|
from run_agent import AIAgent
|
|
|
|
|
|
BERLIN = ZoneInfo("Europe/Berlin")
|
|
|
|
|
|
def _epoch(year, month, day, hour, minute, second):
|
|
return datetime(year, month, day, hour, minute, second, tzinfo=BERLIN).timestamp()
|
|
|
|
|
|
def test_render_user_content_deduplicates_existing_timestamp_and_preserves_embedded_time():
|
|
db_processing_ts = _epoch(2026, 4, 27, 15, 55, 36)
|
|
stored_content = (
|
|
"[Mon 2026-04-27 15:54:44 CEST] "
|
|
"[Example User] This should go on our todo list"
|
|
)
|
|
|
|
rendered = render_user_content_with_timestamp(
|
|
stored_content,
|
|
db_processing_ts,
|
|
tz=BERLIN,
|
|
)
|
|
|
|
assert rendered == stored_content
|
|
assert rendered.count("2026-04-27") == 1
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Opt-in gate: gateway.message_timestamps.enabled (default OFF)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_message_timestamps_enabled_defaults_off():
|
|
from gateway.run import _message_timestamps_enabled
|
|
|
|
assert _message_timestamps_enabled(None) is False
|
|
assert _message_timestamps_enabled({}) is False
|
|
assert _message_timestamps_enabled({"gateway": {}}) is False
|
|
assert (
|
|
_message_timestamps_enabled({"gateway": {"message_timestamps": {}}}) is False
|
|
)
|
|
|
|
|
|
def test_build_history_injects_only_when_enabled():
|
|
from gateway.run import _build_gateway_agent_history
|
|
|
|
history = [
|
|
{"role": "user", "content": "hello", "timestamp": _epoch(2026, 4, 28, 13, 40, 53)},
|
|
{"role": "assistant", "content": "hi"},
|
|
]
|
|
|
|
# Default (off): user content stays clean, no timestamp prefix.
|
|
agent_history, _ = _build_gateway_agent_history(history)
|
|
assert agent_history[0]["content"] == "hello"
|
|
|
|
# Enabled: user content gets exactly one timestamp prefix.
|
|
agent_history, _ = _build_gateway_agent_history(history, inject_timestamps=True)
|
|
assert agent_history[0]["content"].startswith("[")
|
|
assert agent_history[0]["content"].endswith("hello")
|
|
# Assistant message is never timestamped.
|
|
assert agent_history[1]["content"] == "hi"
|