mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
68 lines
2.7 KiB
Python
68 lines
2.7 KiB
Python
"""Contract: media-send overrides must accept the ``metadata`` kwarg.
|
|
|
|
``BasePlatformAdapter.send_multiple_images`` passes ``metadata=metadata``
|
|
to ``send_image`` / ``send_image_file`` / ``send_animation`` on every send.
|
|
An override whose signature stops at ``reply_to`` raises ``TypeError:
|
|
send_image() got an unexpected keyword argument 'metadata'`` at runtime —
|
|
which is exactly how image delivery broke on WhatsApp and email.
|
|
|
|
This mirrors ``test_discord_media_metadata.py`` but covers the two
|
|
adapters that previously slipped, plus a best-effort sweep over every
|
|
adapter that imports cleanly so the next slip is caught at test time.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib
|
|
import inspect
|
|
|
|
import pytest
|
|
|
|
|
|
def _accepts_metadata(method) -> bool:
|
|
params = inspect.signature(method).parameters
|
|
if "metadata" in params:
|
|
return True
|
|
# A ``**kwargs`` catch-all also absorbs metadata (the convention used by
|
|
# WhatsApp's send_video / send_voice / send_document overrides).
|
|
return any(p.kind is inspect.Parameter.VAR_KEYWORD for p in params.values())
|
|
|
|
|
|
# (module, class) for the two adapters this fix targeted. These must import
|
|
# in CI, so assert directly rather than skipping.
|
|
@pytest.mark.parametrize(
|
|
"module_name, class_name",
|
|
[
|
|
("plugins.platforms.whatsapp.adapter", "WhatsAppAdapter"),
|
|
("plugins.platforms.email.adapter", "EmailAdapter"),
|
|
],
|
|
)
|
|
def test_send_image_accepts_metadata(module_name, class_name):
|
|
cls = getattr(importlib.import_module(module_name), class_name)
|
|
assert _accepts_metadata(cls.send_image), (
|
|
f"{class_name}.send_image must accept 'metadata' (or **kwargs) — "
|
|
f"send_multiple_images passes it on every send"
|
|
)
|
|
|
|
|
|
# Best-effort sweep across all shipped adapters. Modules whose optional
|
|
# platform SDK isn't installed are skipped; an adapter that imports but
|
|
# whose override drops metadata is a hard failure.
|
|
_ALL_ADAPTERS = [
|
|
("gateway.platforms.bluebubbles", "BlueBubblesAdapter"),
|
|
("plugins.platforms.dingtalk.adapter", "DingTalkAdapter"),
|
|
("gateway.platforms.discord", "DiscordAdapter"),
|
|
("plugins.platforms.email.adapter", "EmailAdapter"),
|
|
("plugins.platforms.feishu.adapter", "FeishuAdapter"),
|
|
("plugins.platforms.matrix.adapter", "MatrixAdapter"),
|
|
("gateway.platforms.mattermost", "MattermostAdapter"),
|
|
("gateway.platforms.signal", "SignalAdapter"),
|
|
("plugins.platforms.slack.adapter", "SlackAdapter"),
|
|
("plugins.platforms.telegram.adapter", "TelegramAdapter"),
|
|
("plugins.platforms.wecom.adapter", "WeComAdapter"),
|
|
("gateway.platforms.weixin", "WeixinAdapter"),
|
|
("plugins.platforms.whatsapp.adapter", "WhatsAppAdapter"),
|
|
("gateway.platforms.yuanbao", "YuanbaoAdapter"),
|
|
]
|
|
|
|
|