mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
85 lines
2.7 KiB
Python
85 lines
2.7 KiB
Python
"""Tests for the kanban notifier zero-subscription early exit.
|
|
|
|
The notifier used to writable-open EVERY board DB on every tick even when a
|
|
board had zero subscriptions — paying schema init/migration on first open,
|
|
WAL/-shm sidecar creation, and checkpoint traffic for boards with nothing to
|
|
notify. Per-board work is now gated by a read-only subscription probe
|
|
(``kanban_db.count_notify_subs``), so boards with zero subscriptions are
|
|
never opened writable.
|
|
|
|
(The companion machine-global ``.notifier.lock`` singleton gate from PR
|
|
#63001 was deliberately NOT salvaged: a lock-winning default-profile gateway
|
|
cannot deliver a secondary profile's subscriptions in standalone-profile
|
|
deployments — profile routing fails closed in
|
|
``gateway/authz_mixin.py::_authorization_adapter`` — so the lock could
|
|
suppress delivery entirely. The read-only probe captures the per-tick cost
|
|
win without that risk.)
|
|
"""
|
|
|
|
import asyncio
|
|
|
|
from unittest.mock import patch
|
|
|
|
from gateway.config import Platform
|
|
from gateway.run import GatewayRunner
|
|
from hermes_cli import kanban_db as kb
|
|
|
|
|
|
class RecordingAdapter:
|
|
def __init__(self):
|
|
self.sent = []
|
|
|
|
async def send(self, chat_id, text, metadata=None):
|
|
self.sent.append({"chat_id": chat_id, "text": text, "metadata": metadata or {}})
|
|
|
|
|
|
def _make_runner(adapter):
|
|
runner = GatewayRunner.__new__(GatewayRunner)
|
|
runner._running = True
|
|
runner.adapters = {Platform.TELEGRAM: adapter}
|
|
runner._kanban_sub_fail_counts = {}
|
|
return runner
|
|
|
|
|
|
async def _run_one_notifier_tick(monkeypatch, runner):
|
|
real_sleep = asyncio.sleep
|
|
|
|
async def fake_sleep(delay):
|
|
if delay == 5:
|
|
return None
|
|
runner._running = False
|
|
await real_sleep(0)
|
|
|
|
monkeypatch.setattr(asyncio, "sleep", fake_sleep)
|
|
await runner._kanban_notifier_watcher(interval=1)
|
|
|
|
|
|
def _create_completed_task(*, subscribe: bool) -> str:
|
|
conn = kb.connect()
|
|
try:
|
|
tid = kb.create_task(conn, title="owner gate", assignee="worker")
|
|
if subscribe:
|
|
kb.add_notify_sub(conn, task_id=tid, platform="telegram", chat_id="chat-1")
|
|
kb.complete_task(conn, tid, summary="done")
|
|
return tid
|
|
finally:
|
|
conn.close()
|
|
|
|
|
|
def test_zero_sub_board_is_never_opened_writable(tmp_path, monkeypatch):
|
|
"""A board with zero subscriptions must be skipped BEFORE `_kb.connect`."""
|
|
db_path = tmp_path / "zero-subs.db"
|
|
monkeypatch.setenv("HERMES_KANBAN_DB", str(db_path))
|
|
kb.init_db()
|
|
_create_completed_task(subscribe=False)
|
|
|
|
adapter = RecordingAdapter()
|
|
runner = _make_runner(adapter)
|
|
|
|
with patch.object(kb, "connect", wraps=kb.connect) as spy_connect:
|
|
asyncio.run(_run_one_notifier_tick(monkeypatch, runner))
|
|
|
|
spy_connect.assert_not_called()
|
|
assert adapter.sent == []
|
|
|
|
|