mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
54 lines
1.9 KiB
Python
54 lines
1.9 KiB
Python
"""Tests for the dispatch_in_gateway gate on _kanban_notifier_watcher.
|
|
|
|
- Non-dispatch gateways (dispatch_in_gateway=false) exit before opening any DB.
|
|
- HERMES_KANBAN_DISPATCH_IN_GATEWAY env var disables without loading config.
|
|
- Dispatch-owning gateways (dispatch_in_gateway=true) proceed past the gate.
|
|
"""
|
|
|
|
import asyncio
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from gateway.config import Platform
|
|
from gateway.run import GatewayRunner
|
|
|
|
|
|
def _make_runner(with_adapter=False):
|
|
runner = GatewayRunner.__new__(GatewayRunner)
|
|
runner._running = True
|
|
runner.adapters = {Platform.TELEGRAM: MagicMock()} if with_adapter else {}
|
|
runner._kanban_sub_fail_counts = {}
|
|
return runner
|
|
|
|
|
|
def _fake_config(dispatch_in_gateway):
|
|
return {"kanban": {"dispatch_in_gateway": dispatch_in_gateway}}
|
|
|
|
|
|
def test_notifier_watcher_runs_when_dispatch_enabled():
|
|
"""dispatch_in_gateway=true proceeds past the gate to the board fan-out."""
|
|
runner = _make_runner(with_adapter=True)
|
|
past_gate = []
|
|
sleep_calls = []
|
|
|
|
async def fake_sleep(delay):
|
|
sleep_calls.append(delay)
|
|
# Stop after the initial delay + first per-interval sleep so the loop
|
|
# body runs exactly once.
|
|
if len(sleep_calls) >= 2:
|
|
runner._running = False
|
|
|
|
async def fake_to_thread(fn, *args, **kwargs):
|
|
return fn(*args, **kwargs)
|
|
|
|
import hermes_cli.kanban_db as _kb
|
|
|
|
with patch("hermes_cli.config.load_config", return_value=_fake_config(True)):
|
|
with patch.object(
|
|
_kb, "list_boards",
|
|
side_effect=lambda *a, **kw: past_gate.append(True) or [],
|
|
):
|
|
with patch("asyncio.sleep", side_effect=fake_sleep):
|
|
with patch("asyncio.to_thread", side_effect=fake_to_thread):
|
|
asyncio.run(runner._kanban_notifier_watcher())
|
|
|
|
assert past_gate, "list_boards should be called when dispatch_in_gateway=true"
|