mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
89 lines
3.1 KiB
Python
89 lines
3.1 KiB
Python
"""Tests for Feishu adapter outbound markdown payload construction.
|
|
|
|
Reproduces the bug tracked in hermes-agent issue #52786:
|
|
`_build_outbound_payload` was force-downgrading any message containing a
|
|
markdown pipe table to ``msg_type=text``, so Feishu clients rendered the raw
|
|
pipe-and-dash source instead of a table. Empirically current Feishu clients
|
|
render ``post``+``md`` tables natively, so the downgrade branch must be removed.
|
|
|
|
These tests guard the fix. They invoke the real adapter via the project's
|
|
plugin-loader helper so that no ``sys.path`` / ``sys.modules`` games are
|
|
needed.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
|
|
from tests.gateway._plugin_adapter_loader import load_plugin_adapter
|
|
|
|
_adapter = load_plugin_adapter("feishu")
|
|
|
|
|
|
def _call_build_outbound_payload(content: str) -> tuple[str, str]:
|
|
"""Invoke ``_build_outbound_payload`` on a bare adapter instance.
|
|
|
|
``_build_outbound_payload`` is a method that only uses module-level
|
|
helpers (``_MARKDOWN_TABLE_RE``, ``_MARKDOWN_HINT_RE``,
|
|
``_build_markdown_post_payload``) and never touches ``self.*``, so a bare
|
|
object is sufficient.
|
|
"""
|
|
inst = object.__new__(_adapter.FeishuAdapter)
|
|
return inst._build_outbound_payload(content)
|
|
|
|
|
|
def _md_texts_from_post_payload(payload_str: str) -> list[str]:
|
|
"""Pull every ``{tag:'md', text:'...'}`` element out of a Feishu post payload.
|
|
|
|
Real payload shape::
|
|
|
|
{"zh_cn": {"content": [[{"tag": "md", "text": "..."}], ...]}}
|
|
|
|
Helpers and tests need to introspect the ``md`` blocks regardless of
|
|
locale, so we walk the structure generically.
|
|
"""
|
|
payload = json.loads(payload_str)
|
|
if not isinstance(payload, dict):
|
|
return []
|
|
texts: list[str] = []
|
|
for lang_val in payload.values():
|
|
if not isinstance(lang_val, dict):
|
|
continue
|
|
content = lang_val.get("content", [])
|
|
if not isinstance(content, list):
|
|
continue
|
|
for block in content:
|
|
if isinstance(block, list):
|
|
candidates = block
|
|
else:
|
|
candidates = [block]
|
|
for el in candidates:
|
|
if isinstance(el, dict) and el.get("tag") == "md":
|
|
texts.append(el.get("text", ""))
|
|
return texts
|
|
|
|
|
|
def test_markdown_table_uses_post_not_text():
|
|
"""Regression test for issue #52786 (and its older sibling #23938).
|
|
|
|
A message whose only markdown is a table must take the ``post`` path,
|
|
not be downgraded to plain text.
|
|
"""
|
|
content = (
|
|
"| col A | col B |\n"
|
|
"| ----- | ----- |\n"
|
|
"| 1 | 2 |"
|
|
)
|
|
msg_type, payload_str = _call_build_outbound_payload(content)
|
|
assert msg_type == "post", (
|
|
f"expected 'post' for a markdown table (issue #52786), got {msg_type!r}; "
|
|
"the table-downgrade branch in _build_outbound_payload has been re-introduced"
|
|
)
|
|
md_texts = _md_texts_from_post_payload(payload_str)
|
|
assert md_texts, f"post payload must include at least one md element; got {payload_str!r}"
|
|
joined = "".join(md_texts)
|
|
assert "col A" in joined and "|" in joined, (
|
|
"table text was lost or reformatted when switching from text to post"
|
|
)
|
|
|
|
|