mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
81 lines
2.5 KiB
Python
81 lines
2.5 KiB
Python
"""Email adapter robustness against malformed IMAP responses (salvage of #2794).
|
|
|
|
Validates that:
|
|
- Malformed IMAP fetch responses are skipped instead of aborting the batch
|
|
(UIDs are marked seen before fetch, so an abort permanently loses messages)
|
|
- Message-ID generation handles a missing '@' in EMAIL_ADDRESS
|
|
"""
|
|
|
|
import os
|
|
import unittest
|
|
import uuid
|
|
from email.mime.text import MIMEText
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
|
|
def _make_adapter(address="hermes@test.com"):
|
|
from gateway.config import PlatformConfig
|
|
|
|
with patch.dict(os.environ, {
|
|
"EMAIL_ADDRESS": address,
|
|
"EMAIL_PASSWORD": "secret",
|
|
"EMAIL_IMAP_HOST": "imap.test.com",
|
|
"EMAIL_SMTP_HOST": "smtp.test.com",
|
|
}):
|
|
from plugins.platforms.email.adapter import EmailAdapter
|
|
|
|
adapter = EmailAdapter(PlatformConfig(enabled=True))
|
|
return adapter
|
|
|
|
|
|
def _raw_email(sender="user@test.com", subject="Hello"):
|
|
msg = MIMEText("Test body", "plain", "utf-8")
|
|
msg["From"] = sender
|
|
msg["Subject"] = subject
|
|
msg["Message-ID"] = f"<{uuid.uuid4().hex[:8]}@test.com>"
|
|
return msg.as_bytes()
|
|
|
|
|
|
class TestImapResponseGuard(unittest.TestCase):
|
|
"""_fetch_new_messages skips messages with unexpected IMAP structure."""
|
|
|
|
def _fetch_with(self, fetch_responses):
|
|
adapter = _make_adapter()
|
|
uids = b" ".join(
|
|
str(i + 1).encode() for i in range(len(fetch_responses))
|
|
)
|
|
fetch_iter = iter(fetch_responses)
|
|
|
|
def uid_handler(command, *args):
|
|
if command == "search":
|
|
return ("OK", [uids])
|
|
if command == "fetch":
|
|
return next(fetch_iter)
|
|
return ("NO", [])
|
|
|
|
mock_imap = MagicMock()
|
|
mock_imap.uid.side_effect = uid_handler
|
|
with patch("imaplib.IMAP4_SSL", return_value=mock_imap):
|
|
return adapter._fetch_new_messages()
|
|
|
|
def test_normal_response_parses(self):
|
|
results = self._fetch_with([("OK", [(b"1 (RFC822 {123}", _raw_email())])])
|
|
self.assertEqual(len(results), 1)
|
|
self.assertEqual(results[0]["sender_addr"], "user@test.com")
|
|
|
|
def test_none_element_skipped(self):
|
|
results = self._fetch_with([("OK", [None])])
|
|
self.assertEqual(results, [])
|
|
|
|
|
|
class TestMessageIdDomain(unittest.TestCase):
|
|
"""Message-ID generation tolerates EMAIL_ADDRESS without '@'."""
|
|
|
|
|
|
def test_address_without_at(self):
|
|
adapter = _make_adapter("not-an-email")
|
|
self.assertEqual(adapter._message_id_domain(), "localhost")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|