mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
61 lines
2.1 KiB
Python
61 lines
2.1 KiB
Python
"""#5 regression: _session_has_compression_in_flight must offload both blocking sources to thread pool."""
|
|
import inspect
|
|
import threading
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
|
|
|
|
def _make_runner(holder_value=None, record_thread=False, thread_sink=None):
|
|
from gateway.run import GatewayRunner
|
|
runner = GatewayRunner.__new__(GatewayRunner)
|
|
|
|
store = MagicMock()
|
|
store._lock = threading.Lock()
|
|
store._loaded = True
|
|
store._entries = {"k": MagicMock(session_id="sess-123")}
|
|
store._ensure_loaded_locked = lambda: None
|
|
runner.session_store = store
|
|
|
|
raw_db = MagicMock()
|
|
if record_thread and thread_sink is not None:
|
|
def _holder(sid):
|
|
thread_sink["thread"] = threading.get_ident()
|
|
return holder_value
|
|
raw_db.get_compression_lock_holder = _holder
|
|
else:
|
|
raw_db.get_compression_lock_holder = MagicMock(return_value=holder_value)
|
|
|
|
session_db = MagicMock()
|
|
session_db._db = raw_db
|
|
runner._session_db = session_db
|
|
return runner
|
|
|
|
|
|
def test_method_is_coroutine():
|
|
from gateway.run import GatewayRunner
|
|
assert inspect.iscoroutinefunction(
|
|
GatewayRunner._session_has_compression_in_flight
|
|
), "#5: method must be async, blocking calls offloaded"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_returns_false_when_no_session_store():
|
|
from gateway.run import GatewayRunner
|
|
runner = GatewayRunner.__new__(GatewayRunner)
|
|
runner.session_store = None
|
|
runner._session_db = MagicMock()
|
|
assert await runner._session_has_compression_in_flight("k") is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_db_call_runs_off_event_loop():
|
|
"""Regression core: get_compression_lock_holder MUST execute in non-event-loop thread."""
|
|
sink = {}
|
|
runner = _make_runner(holder_value="agent-1", record_thread=True, thread_sink=sink)
|
|
loop_thread = threading.get_ident()
|
|
await runner._session_has_compression_in_flight("k")
|
|
assert "thread" in sink, "underlying db.get_compression_lock_holder was not called"
|
|
assert sink["thread"] != loop_thread, (
|
|
"DB call still on event loop thread — #5 NOT fixed (to_thread not applied)"
|
|
)
|