mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
285 lines
9.7 KiB
Python
285 lines
9.7 KiB
Python
import asyncio
|
|
import sys
|
|
import threading
|
|
import types
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import gateway.run as gateway_run
|
|
from gateway.config import Platform
|
|
from gateway.session import SessionSource
|
|
|
|
|
|
SESSION_KEY = "agent:main:telegram:dm:12345"
|
|
|
|
|
|
class _SessionStore:
|
|
def __init__(self):
|
|
self.entry = SimpleNamespace(
|
|
session_key=SESSION_KEY,
|
|
session_id="session-before-compression",
|
|
)
|
|
self._entries = {SESSION_KEY: self.entry}
|
|
self.save_calls = 0
|
|
self.peer_records = []
|
|
|
|
def _save(self):
|
|
self.save_calls += 1
|
|
|
|
def _record_gateway_session_peer(self, session_id, session_key, source):
|
|
# #55300 records the child's gateway peer metadata after a compression
|
|
# split; the fake tracks the call so tests can assert it fired.
|
|
self.peer_records.append((session_id, session_key, source))
|
|
|
|
|
|
class _CompressionThenFailureAgent:
|
|
def __init__(self, **kwargs):
|
|
self.session_id = kwargs["session_id"]
|
|
self.model = kwargs["model"]
|
|
self.tools = []
|
|
self.context_compressor = SimpleNamespace(
|
|
last_prompt_tokens=4321,
|
|
context_length=200000,
|
|
)
|
|
self.session_prompt_tokens = 4321
|
|
self.session_completion_tokens = 0
|
|
|
|
def run_conversation(
|
|
self, user_message, conversation_history=None, task_id=None, **_kwargs
|
|
):
|
|
self.session_id = "session-after-compression"
|
|
return {
|
|
"failed": True,
|
|
"error": "APIConnectionError: Codex auxiliary Responses stream exceeded 120.0s total timeout",
|
|
"messages": [
|
|
{"role": "user", "content": "[compressed summary]"},
|
|
{"role": "user", "content": user_message},
|
|
],
|
|
"api_calls": 1,
|
|
}
|
|
|
|
def interrupt(self, *_args, **_kwargs):
|
|
pass
|
|
|
|
|
|
class _StreamConsumer:
|
|
final_response_sent = False
|
|
|
|
def __init__(self, *_args, **_kwargs):
|
|
pass
|
|
|
|
async def run(self):
|
|
return None
|
|
|
|
def finish(self):
|
|
pass
|
|
|
|
|
|
class _Adapter:
|
|
SUPPORTS_MESSAGE_EDITING = True
|
|
_pending_messages = {}
|
|
|
|
def get_pending_message(self, _session_key):
|
|
return None
|
|
|
|
async def send_typing(self, *_args, **_kwargs):
|
|
return None
|
|
|
|
async def stop_typing(self, *_args, **_kwargs):
|
|
return None
|
|
|
|
|
|
def _runner(session_store):
|
|
runner = object.__new__(gateway_run.GatewayRunner)
|
|
runner.adapters = {Platform.TELEGRAM: _Adapter()}
|
|
runner.config = SimpleNamespace(streaming=None, group_sessions_per_user=True, thread_sessions_per_user=False)
|
|
runner.hooks = SimpleNamespace(loaded_hooks=False, emit=AsyncMock())
|
|
runner.session_store = session_store
|
|
runner._session_db = MagicMock()
|
|
runner._session_db.get_telegram_topic_binding_by_session.return_value = None
|
|
runner._agent_cache = {}
|
|
runner._agent_cache_lock = threading.Lock()
|
|
runner._running_agents = {}
|
|
runner._running_agents_ts = {}
|
|
runner._session_run_generation = {}
|
|
runner._session_model_overrides = {}
|
|
runner._pending_model_notes = {}
|
|
runner._pending_skills_reload_notes = {}
|
|
runner._prefill_messages = []
|
|
runner._ephemeral_system_prompt = ""
|
|
runner._reasoning_config = None
|
|
runner._provider_routing = {}
|
|
runner._fallback_model = None
|
|
runner._draining = False
|
|
runner._get_proxy_url = lambda: None
|
|
runner._resolve_session_agent_runtime = lambda **_kwargs: (
|
|
"gpt-5.4",
|
|
{"provider": "openai-codex", "api_mode": "codex_responses", "base_url": "https://chatgpt.com/backend-api/codex", "api_key": "token"},
|
|
)
|
|
runner._resolve_session_reasoning_config = lambda **_kwargs: None
|
|
runner._resolve_turn_agent_config = lambda message, model, runtime: {"model": model, "runtime": runtime}
|
|
runner._load_service_tier = lambda: None
|
|
runner._agent_config_signature = lambda *_args, **_kwargs: ("sig",)
|
|
runner._extract_cache_busting_config = lambda _config: ()
|
|
runner._thread_metadata_for_source = lambda *_args, **_kwargs: None
|
|
runner._sync_telegram_topic_binding = MagicMock()
|
|
runner._release_running_agent_state = MagicMock()
|
|
return runner
|
|
|
|
|
|
def _install_compression_failure_agent(monkeypatch, agent_cls=_CompressionThenFailureAgent):
|
|
fake_run_agent = types.ModuleType("run_agent")
|
|
fake_run_agent.AIAgent = agent_cls
|
|
monkeypatch.setitem(sys.modules, "run_agent", fake_run_agent)
|
|
monkeypatch.setenv("HERMES_TOOL_PROGRESS_MODE", "off")
|
|
monkeypatch.setenv("HERMES_AGENT_TIMEOUT", "0")
|
|
monkeypatch.setattr(gateway_run, "_load_gateway_config", lambda: {})
|
|
monkeypatch.setattr("gateway.stream_consumer.GatewayStreamConsumer", _StreamConsumer)
|
|
|
|
import hermes_cli.tools_config as tools_config
|
|
|
|
monkeypatch.setattr(tools_config, "_get_platform_tools", lambda *_args, **_kwargs: {"core"})
|
|
|
|
|
|
def _run_compression_failure_turn(runner, source, *, run_generation=None):
|
|
return asyncio.run(
|
|
asyncio.wait_for(
|
|
runner._run_agent(
|
|
message="continue",
|
|
context_prompt="",
|
|
history=[{"role": "user", "content": "old question"}],
|
|
source=source,
|
|
session_id="session-before-compression",
|
|
session_key=SESSION_KEY,
|
|
run_generation=run_generation,
|
|
),
|
|
timeout=2,
|
|
)
|
|
)
|
|
|
|
|
|
def test_failed_turn_still_syncs_compression_session_split(monkeypatch):
|
|
_install_compression_failure_agent(monkeypatch)
|
|
|
|
session_store = _SessionStore()
|
|
runner = _runner(session_store)
|
|
source = SessionSource(platform=Platform.TELEGRAM, chat_id="12345", chat_type="dm", user_id="user-1")
|
|
|
|
result = _run_compression_failure_turn(runner, source)
|
|
|
|
assert result["failed"] is True
|
|
assert result["session_id"] == "session-after-compression"
|
|
assert result["history_offset"] == 0
|
|
assert session_store.entry.session_id == "session-after-compression"
|
|
assert session_store.save_calls == 1
|
|
# #55300: the child's gateway peer metadata is recorded on the persist path.
|
|
assert session_store.peer_records == [
|
|
("session-after-compression", SESSION_KEY, source)
|
|
]
|
|
runner._sync_telegram_topic_binding.assert_called_once_with(
|
|
source, session_store.entry, reason="agent-run-compression"
|
|
)
|
|
|
|
|
|
class _RateLimitFailureAgent(_CompressionThenFailureAgent):
|
|
def run_conversation(self, user_message, conversation_history=None, task_id=None, **_kwargs):
|
|
return {
|
|
"final_response": "API call failed after 3 retries: 429 Too Many Requests",
|
|
"failed": True,
|
|
"completed": False,
|
|
"error": "429 Too Many Requests",
|
|
"failure_reason": "rate_limit",
|
|
"messages": [
|
|
*(conversation_history or []),
|
|
{"role": "user", "content": user_message},
|
|
],
|
|
"api_calls": 3,
|
|
}
|
|
|
|
|
|
class _EmptyRateLimitFailureAgent(_CompressionThenFailureAgent):
|
|
def run_conversation(self, user_message, conversation_history=None, task_id=None, **_kwargs):
|
|
return {
|
|
"final_response": "",
|
|
"failed": True,
|
|
"completed": False,
|
|
"error": "429 Too Many Requests",
|
|
"failure_reason": "rate_limit",
|
|
"messages": [
|
|
*(conversation_history or []),
|
|
{"role": "user", "content": user_message},
|
|
],
|
|
"api_calls": 3,
|
|
}
|
|
|
|
|
|
def test_empty_rate_limit_response_preserves_failure_metadata(monkeypatch):
|
|
"""Sibling of the non-empty path (#64686): the empty-response return
|
|
branch in _run_agent must also forward failure_reason, or downstream
|
|
consumers lose the structured reason exactly when the run produced no
|
|
text at all."""
|
|
_install_compression_failure_agent(monkeypatch, _EmptyRateLimitFailureAgent)
|
|
|
|
session_store = _SessionStore()
|
|
runner = _runner(session_store)
|
|
source = SessionSource(
|
|
platform=Platform.TELEGRAM,
|
|
chat_id="12345",
|
|
chat_type="dm",
|
|
user_id="user-1",
|
|
)
|
|
|
|
result = _run_compression_failure_turn(runner, source)
|
|
|
|
assert result["failed"] is True
|
|
assert result["failure_reason"] == "rate_limit"
|
|
assert result["completed"] is False
|
|
|
|
class _ProviderSwitchAgent(_CompressionThenFailureAgent):
|
|
created_providers = []
|
|
second_turn_history = None
|
|
|
|
def __init__(self, **kwargs):
|
|
super().__init__(**kwargs)
|
|
self.provider = kwargs.get("provider")
|
|
self.base_url = kwargs.get("base_url")
|
|
self.api_key = kwargs.get("api_key")
|
|
self.api_mode = kwargs.get("api_mode")
|
|
type(self).created_providers.append(self.provider)
|
|
|
|
def run_conversation(
|
|
self, user_message, conversation_history=None, task_id=None, **_kwargs
|
|
):
|
|
history = list(conversation_history or [])
|
|
|
|
if self.provider == "provider-a":
|
|
return {
|
|
"final_response": (
|
|
"API call failed after 3 retries: 429 Too Many Requests"
|
|
),
|
|
"failed": True,
|
|
"completed": False,
|
|
"error": "429 Too Many Requests",
|
|
"failure_reason": "rate_limit",
|
|
"messages": [
|
|
*history,
|
|
{"role": "user", "content": user_message},
|
|
],
|
|
"api_calls": 3,
|
|
}
|
|
|
|
type(self).second_turn_history = history
|
|
response = "Provider B completed the next turn"
|
|
return {
|
|
"final_response": response,
|
|
"failed": False,
|
|
"completed": True,
|
|
"messages": [
|
|
*history,
|
|
{"role": "user", "content": user_message},
|
|
{"role": "assistant", "content": response},
|
|
],
|
|
"api_calls": 1,
|
|
}
|
|
|
|
|