mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
35 lines
1.3 KiB
Python
35 lines
1.3 KiB
Python
"""Session-based channel discovery must not resurrect disconnected platforms.
|
|
|
|
Surgical reapply of the directory portion of PR #25959: historical session
|
|
origins for platforms with no connected adapter must not become active
|
|
send_message targets."""
|
|
|
|
import asyncio
|
|
from unittest.mock import patch
|
|
|
|
from gateway.channel_directory import build_channel_directory
|
|
from gateway.platforms.base import Platform
|
|
|
|
|
|
def test_does_not_resurrect_disconnected_platforms_from_session_history(tmp_path, monkeypatch):
|
|
cache_file = tmp_path / "channel_directory.json"
|
|
|
|
calls = []
|
|
|
|
def fake_build_from_sessions(plat_name):
|
|
calls.append(plat_name)
|
|
return {"channels": [{"id": "1", "name": "old"}]}
|
|
|
|
with patch("gateway.channel_directory._build_from_sessions", side_effect=fake_build_from_sessions), \
|
|
patch("gateway.channel_directory.DIRECTORY_PATH", cache_file):
|
|
# Only telegram is connected; no discord/slack/whatsapp adapters.
|
|
directory = asyncio.run(build_channel_directory({Platform.TELEGRAM: object()}))
|
|
|
|
plats = directory["platforms"]
|
|
assert "telegram" in plats
|
|
# Disconnected platforms must not appear via session discovery.
|
|
for stale in ("whatsapp", "signal", "matrix"):
|
|
assert stale not in plats, f"{stale} resurrected from session history"
|
|
assert set(calls) <= {"telegram"}
|
|
|
|
|