mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
104 lines
3.4 KiB
Python
104 lines
3.4 KiB
Python
"""Tests for the lightweight Slack/Discord channel session-continuity hint.
|
|
|
|
Salvaged from PR #36220 (metamon-p), ported onto the current SessionStore.
|
|
|
|
Covers:
|
|
- SessionStore records the previous session_id on auto-reset (and only then).
|
|
- prev_session_id survives a to_dict() → from_dict() roundtrip (gateway restart).
|
|
- build_channel_continuity_note() emits a hint only for Slack/Discord sessions
|
|
that were auto-reset with real prior activity, and stays silent otherwise.
|
|
"""
|
|
|
|
from datetime import datetime, timedelta
|
|
|
|
import pytest
|
|
|
|
from gateway.config import GatewayConfig, Platform, SessionResetPolicy
|
|
from gateway.session import (
|
|
SessionEntry,
|
|
SessionSource,
|
|
SessionStore,
|
|
build_channel_continuity_note,
|
|
)
|
|
|
|
|
|
@pytest.fixture()
|
|
def _isolated_db(tmp_path, monkeypatch):
|
|
import hermes_state
|
|
|
|
monkeypatch.setattr(hermes_state, "DEFAULT_DB_PATH", tmp_path / "state.db")
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
return tmp_path
|
|
|
|
|
|
def _make_store(tmp_path, policy=None):
|
|
config = GatewayConfig()
|
|
if policy:
|
|
config.default_reset_policy = policy
|
|
return SessionStore(sessions_dir=tmp_path / "sessions", config=config)
|
|
|
|
|
|
def _slack_source(thread_id=None):
|
|
return SessionSource(
|
|
platform=Platform.SLACK,
|
|
chat_id="C123",
|
|
chat_type="thread" if thread_id else "channel",
|
|
user_id="U1",
|
|
thread_id=thread_id,
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# SessionStore records prev_session_id on auto-reset
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestPrevSessionIdCapture:
|
|
def test_prev_session_id_set_on_auto_reset(self, _isolated_db, tmp_path):
|
|
store = _make_store(tmp_path, SessionResetPolicy(mode="idle", idle_minutes=1))
|
|
source = _slack_source(thread_id="T9")
|
|
|
|
entry1 = store.get_or_create_session(source)
|
|
assert entry1.prev_session_id is None # fresh session, nothing replaced
|
|
|
|
entry1.last_prompt_tokens = 4000 # had real conversation
|
|
entry1.updated_at = datetime.now() - timedelta(minutes=5)
|
|
store._save()
|
|
|
|
entry2 = store.get_or_create_session(source)
|
|
assert entry2.was_auto_reset is True
|
|
assert entry2.reset_had_activity is True
|
|
assert entry2.prev_session_id == entry1.session_id
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# build_channel_continuity_note
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def _reset_entry(platform, prev="20260101_000000_abc", had_activity=True):
|
|
return SessionEntry(
|
|
session_key="k",
|
|
session_id="20260101_010000_def",
|
|
created_at=datetime.now(),
|
|
updated_at=datetime.now(),
|
|
platform=platform,
|
|
was_auto_reset=True,
|
|
auto_reset_reason="daily",
|
|
reset_had_activity=had_activity,
|
|
prev_session_id=prev,
|
|
)
|
|
|
|
|
|
class TestBuildChannelContinuityNote:
|
|
def test_slack_channel_emits_hint(self):
|
|
entry = _reset_entry(Platform.SLACK)
|
|
note = build_channel_continuity_note(entry, _slack_source())
|
|
assert note is not None
|
|
assert "session_search" in note
|
|
assert entry.prev_session_id in note
|
|
assert "channel" in note
|
|
|
|
|
|
def test_no_activity_returns_none(self):
|
|
entry = _reset_entry(Platform.SLACK, had_activity=False)
|
|
assert build_channel_continuity_note(entry, _slack_source()) is None
|
|
|