mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
54 lines
1.9 KiB
Python
54 lines
1.9 KiB
Python
"""Unit tests for relay wire-field hygiene (Phase 1 parity).
|
|
|
|
Covers _event_from_wire's consumption of the contract §3 user-identity
|
|
enrichment fields the connector has always sent but the gateway used to drop:
|
|
|
|
- ``user_display_name`` — the human-facing display name (native parity: the
|
|
native Discord adapter surfaces ``message.author.display_name`` as
|
|
``user_name``).
|
|
- ``user_handle`` — the raw platform handle, used only as a last resort.
|
|
|
|
Precedence: user_display_name > user_name > user_handle. Session keys derive
|
|
from user_id (never user_name), so this mapping is presentation-only and must
|
|
remain key-stable — asserted here via build_session_key.
|
|
|
|
Pure unit tests: no socket, no websockets dependency.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from gateway.relay.ws_transport import _event_from_wire
|
|
from gateway.session import build_session_key
|
|
|
|
|
|
def _wire_event(**src_overrides):
|
|
src = {
|
|
"platform": "discord",
|
|
"chat_id": "chan-1",
|
|
"chat_type": "group",
|
|
"user_id": "u-1",
|
|
"user_name": "rawusername",
|
|
"scope_id": "guild-1",
|
|
}
|
|
src.update(src_overrides)
|
|
return {"text": "hello", "message_type": "text", "source": src}
|
|
|
|
|
|
class TestUserIdentityEnrichment:
|
|
|
|
|
|
def test_handle_is_last_resort(self):
|
|
ev = _event_from_wire(
|
|
_wire_event(user_name=None, user_handle="ben#1234")
|
|
)
|
|
assert ev.source.user_name == "ben#1234"
|
|
|
|
|
|
def test_session_key_is_stable_across_name_shapes(self):
|
|
"""user_name is presentation-only: the same user_id keys the same
|
|
session whether or not the connector sent the enrichment fields."""
|
|
plain = _event_from_wire(_wire_event())
|
|
enriched = _event_from_wire(
|
|
_wire_event(user_display_name="Ben Display", user_handle="ben#1234")
|
|
)
|
|
assert build_session_key(plain.source) == build_session_key(enriched.source)
|