mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
73 lines
No EOL
2.2 KiB
Python
73 lines
No EOL
2.2 KiB
Python
"""Runtime smoke tests for Docker PUID/PGID and UID/GID remap.
|
|
|
|
Build the real image and verify the actual runtime behavior:
|
|
|
|
1. PUID/PGID env vars remap the hermes user UID/GID at boot
|
|
2. HERMES_UID/HERMES_GID take precedence over PUID/PGID aliases
|
|
3. NAS-style low UIDs (99:100) are accepted and remapped
|
|
4. Invalid UIDs are rejected
|
|
5. The remapped user can write to the data volume
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from tests.docker.conftest import docker_exec_sh, start_container
|
|
|
|
|
|
def test_puid_pgid_remaps_hermes_user(
|
|
built_image: str, container_name: str,
|
|
) -> None:
|
|
"""PUID=1000 PGID=1000 must remap the hermes user to UID 1000."""
|
|
start_container(built_image, container_name, "PUID=1000", "PGID=1000")
|
|
|
|
r = docker_exec_sh(
|
|
container_name,
|
|
"id -u hermes",
|
|
timeout=10,
|
|
)
|
|
assert r.stdout.strip() == "1000", (
|
|
f"expected hermes UID 1000 after PUID remap, got: {r.stdout.strip()}"
|
|
)
|
|
|
|
r = docker_exec_sh(
|
|
container_name,
|
|
"id -g hermes",
|
|
timeout=10,
|
|
)
|
|
assert r.stdout.strip() == "1000", (
|
|
f"expected hermes GID 1000 after PGID remap, got: {r.stdout.strip()}"
|
|
)
|
|
|
|
|
|
|
|
|
|
def test_nas_low_uid_accepted(
|
|
built_image: str, container_name: str,
|
|
) -> None:
|
|
"""NAS-style low UIDs (99:100, common on Unraid) must be accepted."""
|
|
start_container(built_image, container_name, "PUID=99", "PGID=100")
|
|
|
|
r = docker_exec_sh(container_name, "id -u hermes", timeout=10)
|
|
assert r.stdout.strip() == "99", (
|
|
f"expected hermes UID 99, got: {r.stdout.strip()}"
|
|
)
|
|
|
|
r = docker_exec_sh(container_name, "id -g hermes", timeout=10)
|
|
assert r.stdout.strip() == "100", (
|
|
f"expected hermes GID 100, got: {r.stdout.strip()}"
|
|
)
|
|
|
|
|
|
def test_remap_enables_data_volume_writes(
|
|
built_image: str, container_name: str,
|
|
) -> None:
|
|
"""After remap, the hermes user must be able to write to /opt/data."""
|
|
start_container(built_image, container_name, "PUID=1000", "PGID=1000")
|
|
|
|
r = docker_exec_sh(
|
|
container_name,
|
|
"touch /opt/data/test_write && echo WRITE_OK || echo WRITE_FAIL",
|
|
timeout=10,
|
|
)
|
|
assert "WRITE_OK" in r.stdout, (
|
|
f"hermes user cannot write to /opt/data after remap: {r.stdout}"
|
|
) |