mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
64 lines
1.9 KiB
Python
64 lines
1.9 KiB
Python
"""Tests for on_jobs_changed wiring (Phase 4F.1).
|
|
|
|
After a store mutation via the consumer surfaces (model tool / CLI / REST), the
|
|
active scheduler provider's on_jobs_changed() must be invoked so an external
|
|
provider (Chronos) re-provisions/cancels. The built-in's no-op default means
|
|
the default path is unchanged.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def temp_home(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
yield tmp_path
|
|
|
|
|
|
def test_notify_helper_calls_provider_on_jobs_changed(monkeypatch):
|
|
"""cron.scheduler._notify_provider_jobs_changed resolves the provider and
|
|
calls on_jobs_changed exactly once."""
|
|
import cron.scheduler_provider as sp
|
|
import cron.scheduler as sched
|
|
|
|
calls = []
|
|
|
|
class Spy(sp.CronScheduler):
|
|
@property
|
|
def name(self):
|
|
return "spy"
|
|
|
|
def start(self, stop_event, **kw):
|
|
pass
|
|
|
|
def on_jobs_changed(self):
|
|
calls.append(1)
|
|
|
|
monkeypatch.setattr(sp, "resolve_cron_scheduler", lambda: Spy())
|
|
sched._notify_provider_jobs_changed()
|
|
assert calls == [1]
|
|
|
|
|
|
def test_builtin_notify_is_harmless(monkeypatch):
|
|
"""With the built-in provider (default), notify is a no-op and never
|
|
raises."""
|
|
import cron.scheduler as sched
|
|
# default resolution → built-in; just assert it doesn't blow up.
|
|
sched._notify_provider_jobs_changed()
|
|
|
|
|
|
def test_tool_create_notifies_provider(temp_home, monkeypatch):
|
|
"""Creating a job via the cronjob tool path invokes on_jobs_changed."""
|
|
import cron.scheduler as sched
|
|
calls = []
|
|
monkeypatch.setattr(sched, "_notify_provider_jobs_changed",
|
|
lambda: calls.append("changed"))
|
|
|
|
from tools.cronjob_tools import cronjob
|
|
import json
|
|
|
|
out = json.loads(cronjob(action="create", prompt="echo hi", schedule="every 5m", name="w"))
|
|
assert out["success"] is True
|
|
assert calls == ["changed"]
|
|
|
|
|