mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
21 lines
776 B
Python
21 lines
776 B
Python
"""Tests for the cronjob tool schema shape.
|
|
|
|
Guards the description text that flags ``schedule`` (and ``prompt``) as
|
|
REQUIRED for ``action=create`` — the load-bearing fix for description-driven
|
|
models (e.g. Grok) that omit schedule when the schema only lists ``action``
|
|
in ``required[]``. See issue #32427 / PR #32448.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
|
|
def test_cronjob_schema_action_description_flags_create_requirements():
|
|
"""`action` description must state schedule + prompt are required for create."""
|
|
from tools.cronjob_tools import CRONJOB_SCHEMA
|
|
|
|
action_desc = CRONJOB_SCHEMA["parameters"]["properties"]["action"]["description"]
|
|
assert "action=create" in action_desc
|
|
assert "schedule" in action_desc
|
|
assert "REQUIRED" in action_desc
|
|
|
|
|