mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
69 lines
2.7 KiB
Python
69 lines
2.7 KiB
Python
"""Regression tests for #4707 — cron must be per-profile.
|
|
|
|
Design intent (Teknium, June 2026): a profile's cron jobs both LIVE in that
|
|
profile's HERMES_HOME and EXECUTE under it.
|
|
|
|
- Storage: a job created under profile ``coder`` writes to
|
|
``~/.hermes/profiles/coder/cron/jobs.json`` — NOT the shared default root.
|
|
- Execution: the profile-scoped gateway's in-process ticker resolves the
|
|
active HERMES_HOME (profile home) at call time, so jobs run with that
|
|
profile's ``.env`` / ``config.yaml`` / scripts / skills.
|
|
|
|
This is the opposite direction from the (reverted) #50112/#32091 "anchor at the
|
|
shared root" approach. Anchoring at the root funnels every profile's jobs into
|
|
one store and runs them under whatever HERMES_HOME the ticker happens to have —
|
|
leaking config/credentials/skills across profiles, the security boundary #4707
|
|
was filed for. These tests pin per-profile isolation so a stale-branch merge or
|
|
a re-anchor "fix" can't silently flip it back.
|
|
"""
|
|
import importlib
|
|
from pathlib import Path
|
|
|
|
|
|
def _set_profile_env(monkeypatch, root: Path, profile_home: Path) -> None:
|
|
"""Pretend the platform default root is ``root`` and the active
|
|
HERMES_HOME is a profile under it (``<root>/profiles/<name>``)."""
|
|
import hermes_constants
|
|
|
|
monkeypatch.setattr(
|
|
hermes_constants, "_get_platform_default_hermes_home", lambda: root
|
|
)
|
|
monkeypatch.setenv("HERMES_HOME", str(profile_home))
|
|
|
|
|
|
def test_cron_storage_anchors_at_profile_home(tmp_path, monkeypatch):
|
|
"""Under a profile HERMES_HOME (<root>/profiles/<name>), the cron store
|
|
resolves to <profile>/cron, NOT the shared <root>/cron."""
|
|
root = tmp_path / "hermes_home"
|
|
profile_home = root / "profiles" / "coder"
|
|
profile_home.mkdir(parents=True)
|
|
|
|
_set_profile_env(monkeypatch, root, profile_home)
|
|
|
|
import hermes_constants
|
|
|
|
# Sanity: the override is wired the way the gateway sees it.
|
|
assert hermes_constants.get_hermes_home().resolve() == profile_home.resolve()
|
|
assert hermes_constants.get_default_hermes_root().resolve() == root.resolve()
|
|
|
|
# cron/jobs.py computes HERMES_DIR from get_hermes_home() at import, so a
|
|
# fresh import under this env anchors the store at <profile>/cron.
|
|
import cron.jobs as jobs
|
|
|
|
importlib.reload(jobs)
|
|
try:
|
|
assert jobs.HERMES_DIR.resolve() == profile_home.resolve()
|
|
assert (
|
|
jobs.JOBS_FILE.resolve()
|
|
== (profile_home / "cron" / "jobs.json").resolve()
|
|
)
|
|
# The shared-root path must NOT be the store — that would re-break
|
|
# per-profile isolation (#4707).
|
|
assert (
|
|
jobs.JOBS_FILE.resolve() != (root / "cron" / "jobs.json").resolve()
|
|
)
|
|
finally:
|
|
monkeypatch.undo()
|
|
importlib.reload(jobs)
|
|
|
|
|