mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
81 lines
2.4 KiB
Python
81 lines
2.4 KiB
Python
"""Tests for agent/runtime_cwd.py — the single source of truth for the agent working directory."""
|
|
|
|
import os
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
import agent.runtime_cwd as rt
|
|
from agent.runtime_cwd import (
|
|
clear_session_cwd,
|
|
resolve_agent_cwd,
|
|
resolve_context_cwd,
|
|
set_session_cwd,
|
|
)
|
|
|
|
|
|
def _raise_oserror(*args, **kwargs):
|
|
raise OSError("cwd gone")
|
|
|
|
|
|
class TestResolveAgentCwd:
|
|
def test_prefers_terminal_cwd_over_getcwd(self, monkeypatch, tmp_path):
|
|
monkeypatch.setenv("TERMINAL_CWD", str(tmp_path))
|
|
monkeypatch.chdir(os.path.expanduser("~"))
|
|
assert resolve_agent_cwd() == tmp_path
|
|
|
|
|
|
|
|
|
|
|
|
def test_propagates_oserror_from_getcwd(self, monkeypatch):
|
|
# The fallback arm calls os.getcwd(), which can raise OSError (deleted cwd).
|
|
# The resolver must NOT swallow it — build_environment_hints owns the
|
|
# try/except OSError guard at the call site (prompt_builder.py:805).
|
|
monkeypatch.delenv("TERMINAL_CWD", raising=False)
|
|
monkeypatch.setattr(rt.os, "getcwd", _raise_oserror)
|
|
with pytest.raises(OSError):
|
|
resolve_agent_cwd()
|
|
|
|
|
|
class TestResolveContextCwd:
|
|
def test_returns_dir_when_set(self, monkeypatch, tmp_path):
|
|
monkeypatch.setenv("TERMINAL_CWD", str(tmp_path))
|
|
assert resolve_context_cwd() == tmp_path
|
|
|
|
|
|
|
|
|
|
def test_expands_leading_tilde(self, monkeypatch):
|
|
monkeypatch.setenv("TERMINAL_CWD", "~")
|
|
assert resolve_context_cwd() == Path(os.path.expanduser("~"))
|
|
|
|
|
|
|
|
class TestSessionCwdOverride:
|
|
"""The #29531 per-session arm: a contextvar cwd wins over TERMINAL_CWD so a
|
|
multi-session gateway can pin each session to its own folder."""
|
|
|
|
def test_session_cwd_overrides_terminal_cwd(self, monkeypatch, tmp_path):
|
|
other = tmp_path / "other"
|
|
other.mkdir()
|
|
monkeypatch.setenv("TERMINAL_CWD", str(tmp_path))
|
|
token = set_session_cwd(str(other))
|
|
try:
|
|
assert resolve_agent_cwd() == other
|
|
assert resolve_context_cwd() == other
|
|
finally:
|
|
rt._SESSION_CWD.reset(token)
|
|
|
|
|
|
def test_clear_session_cwd_restores_terminal_cwd(self, monkeypatch, tmp_path):
|
|
other = tmp_path / "other"
|
|
other.mkdir()
|
|
monkeypatch.setenv("TERMINAL_CWD", str(tmp_path))
|
|
token = set_session_cwd(str(other))
|
|
try:
|
|
clear_session_cwd()
|
|
assert resolve_agent_cwd() == tmp_path
|
|
finally:
|
|
rt._SESSION_CWD.reset(token)
|
|
|