mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
60 lines
1.8 KiB
Python
60 lines
1.8 KiB
Python
"""Tests for per-platform prompt-hint overrides (config.yaml → platform_hints).
|
|
|
|
Covers agent/system_prompt.py::_resolve_platform_hint — the resolver that
|
|
applies append/replace overrides to a platform's default hint. Feature added
|
|
for enterprise managed profiles (per-platform behavior without affecting other
|
|
platforms). See HA Core ticket: configurable per-platform prompt hints.
|
|
"""
|
|
|
|
import types
|
|
|
|
from agent.system_prompt import _resolve_platform_hint
|
|
|
|
|
|
def _agent(overrides):
|
|
"""Minimal stand-in carrying just the override attribute the resolver reads."""
|
|
a = types.SimpleNamespace()
|
|
a._platform_hint_overrides = overrides
|
|
return a
|
|
|
|
|
|
DEFAULT = "You are on WhatsApp. Do not use markdown."
|
|
EXTRA = "When tabular output would help, invoke the table_formatting skill."
|
|
|
|
|
|
class TestResolvePlatformHint:
|
|
|
|
def test_missing_attr_returns_default(self):
|
|
a = types.SimpleNamespace() # no _platform_hint_overrides at all
|
|
assert _resolve_platform_hint(a, "whatsapp", DEFAULT) == DEFAULT
|
|
|
|
|
|
def test_append_dict(self):
|
|
a = _agent({"whatsapp": {"append": EXTRA}})
|
|
out = _resolve_platform_hint(a, "whatsapp", DEFAULT)
|
|
assert out == f"{DEFAULT}\n\n{EXTRA}"
|
|
assert DEFAULT in out and EXTRA in out
|
|
|
|
def test_replace_dict(self):
|
|
a = _agent({"whatsapp": {"replace": EXTRA}})
|
|
out = _resolve_platform_hint(a, "whatsapp", DEFAULT)
|
|
assert out == EXTRA
|
|
assert DEFAULT not in out
|
|
|
|
|
|
|
|
def test_other_platform_unaffected(self):
|
|
"""An override for whatsapp must not change telegram's hint."""
|
|
a = _agent({"whatsapp": {"append": EXTRA}})
|
|
tg_default = "You are on Telegram. Markdown works."
|
|
assert _resolve_platform_hint(a, "telegram", tg_default) == tg_default
|
|
|
|
|
|
# --- defensive / malformed input: never break prompt assembly ---
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|