mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
81 lines
2.5 KiB
Python
81 lines
2.5 KiB
Python
from types import SimpleNamespace
|
|
from unittest.mock import patch
|
|
|
|
|
|
|
|
def _response(content="ok"):
|
|
message = SimpleNamespace(content=content, tool_calls=[])
|
|
choice = SimpleNamespace(message=message, finish_reason="stop")
|
|
return SimpleNamespace(choices=[choice], usage=None, model="fake")
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_slot_reasoning_config_parses_effort_and_none():
|
|
from agent.moa_loop import _slot_reasoning_config
|
|
|
|
assert _slot_reasoning_config({"reasoning_effort": "high"}) == {
|
|
"enabled": True,
|
|
"effort": "high",
|
|
}
|
|
assert _slot_reasoning_config({"reasoning_effort": "none"}) == {"enabled": False}
|
|
assert _slot_reasoning_config({}) is None
|
|
|
|
|
|
|
|
def test_moa_reference_passes_per_slot_reasoning_config(monkeypatch):
|
|
from agent.moa_loop import _run_reference
|
|
|
|
captured = {}
|
|
|
|
def fake_call_llm(**kwargs):
|
|
captured.update(kwargs)
|
|
return _response("advice")
|
|
|
|
monkeypatch.setattr("agent.moa_loop.call_llm", fake_call_llm)
|
|
with patch("hermes_cli.runtime_provider.resolve_runtime_provider") as mock_resolve:
|
|
mock_resolve.return_value = {"provider": "openai-codex", "model": "gpt-5.6-sol"}
|
|
_run_reference(
|
|
{"provider": "openai-codex", "model": "gpt-5.6-sol", "reasoning_effort": "low"},
|
|
[{"role": "user", "content": "judge this"}],
|
|
)
|
|
|
|
assert captured["reasoning_config"] == {"enabled": True, "effort": "low"}
|
|
|
|
|
|
|
|
|
|
|
|
class TestAggregatorGlobalFallback:
|
|
"""#64187: the aggregator (MoA's acting model) resolves like any acting
|
|
model when its slot has no reasoning_effort: per-model override
|
|
(agent.reasoning_overrides for the slot's model) > global
|
|
agent.reasoning_effort. Reference advisors do NOT get this fallback
|
|
(side calls — cost containment)."""
|
|
|
|
|
|
|
|
|
|
|
|
def test_global_yaml_false_disables(self, monkeypatch):
|
|
from agent import moa_loop
|
|
|
|
monkeypatch.setattr(
|
|
"hermes_cli.config.load_config",
|
|
lambda: {"agent": {"reasoning_effort": False}},
|
|
)
|
|
cfg = moa_loop._aggregator_reasoning_config({})
|
|
assert cfg == {"enabled": False}
|
|
|
|
|
|
def test_reference_slots_do_not_inherit_global(self, monkeypatch):
|
|
"""Advisors stay slot-or-default: global effort must NOT leak in."""
|
|
from agent import moa_loop
|
|
|
|
monkeypatch.setattr(
|
|
"hermes_cli.config.load_config",
|
|
lambda: {"agent": {"reasoning_effort": "xhigh"}},
|
|
)
|
|
assert moa_loop._slot_reasoning_config({"provider": "p", "model": "m"}) is None
|