mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
67 lines
2.2 KiB
Python
67 lines
2.2 KiB
Python
"""Reasoning-effort resolution for LM Studio.
|
|
|
|
Covers the contract that Hermes' generic effort ladder must stay monotonic
|
|
once it is mapped onto LM Studio's narrower vocabulary: a stronger requested
|
|
level may resolve to an equal-or-stronger LM Studio level, never a weaker one.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from agent.lmstudio_reasoning import resolve_lmstudio_effort
|
|
from hermes_constants import VALID_REASONING_EFFORTS
|
|
|
|
# Rank of each value LM Studio accepts, weakest to strongest. Used to assert
|
|
# the resolved ladder never inverts.
|
|
_LM_RANK = {"minimal": 0, "low": 1, "medium": 2, "high": 3, "xhigh": 4}
|
|
|
|
|
|
|
|
|
|
def test_effort_ladder_is_monotonic():
|
|
"""Resolving Hermes' canonical ladder never produces an inversion."""
|
|
resolved = [
|
|
resolve_lmstudio_effort({"enabled": True, "effort": effort}, None)
|
|
for effort in VALID_REASONING_EFFORTS
|
|
]
|
|
ranks = [_LM_RANK[value] for value in resolved]
|
|
assert ranks == sorted(ranks), dict(zip(VALID_REASONING_EFFORTS, resolved))
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize("effort", ["max", "ultra"])
|
|
def test_clamped_effort_is_still_checked_against_allowed_options(effort):
|
|
"""A clamped value stays subject to the model's published allowed set.
|
|
|
|
"max" resolves to "xhigh"; a model that does not publish "xhigh" gets the
|
|
field omitted (``None``) so LM Studio applies the model's own default --
|
|
exactly how a directly-requested "xhigh" already behaves.
|
|
"""
|
|
assert (
|
|
resolve_lmstudio_effort(
|
|
{"enabled": True, "effort": effort}, ["off", "minimal", "low"]
|
|
)
|
|
is None
|
|
)
|
|
assert (
|
|
resolve_lmstudio_effort(
|
|
{"enabled": True, "effort": effort}, ["low", "medium", "high", "xhigh"]
|
|
)
|
|
== "xhigh"
|
|
)
|
|
|
|
|
|
def test_clamp_does_not_rewrite_published_allowed_options():
|
|
"""The clamp must not leak into allowed_options normalization.
|
|
|
|
A model publishing "max" is not claiming LM Studio's request vocabulary
|
|
accepts it; allowed_options passes through untouched, so a resolved
|
|
"xhigh" that the model does not publish is still omitted.
|
|
"""
|
|
assert resolve_lmstudio_effort({"enabled": True, "effort": "max"}, ["max"]) is None
|