mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
75 lines
2.2 KiB
Python
75 lines
2.2 KiB
Python
"""Tests for agent/image_gen_registry.py — provider registration & active lookup."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from agent import image_gen_registry
|
|
from agent.image_gen_provider import ImageGenProvider
|
|
|
|
|
|
class _FakeProvider(ImageGenProvider):
|
|
def __init__(self, name: str, available: bool = True):
|
|
self._name = name
|
|
self._available = available
|
|
|
|
@property
|
|
def name(self) -> str:
|
|
return self._name
|
|
|
|
def is_available(self) -> bool:
|
|
return self._available
|
|
|
|
def generate(self, prompt, aspect_ratio="landscape", **kw):
|
|
return {"success": True, "image": f"{self._name}://{prompt}"}
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_registry():
|
|
image_gen_registry._reset_for_tests()
|
|
yield
|
|
image_gen_registry._reset_for_tests()
|
|
|
|
|
|
class TestRegisterProvider:
|
|
|
|
|
|
def test_rejects_empty_name(self):
|
|
class Empty(ImageGenProvider):
|
|
@property
|
|
def name(self) -> str:
|
|
return ""
|
|
|
|
def generate(self, prompt, aspect_ratio="landscape", **kw):
|
|
return {}
|
|
|
|
with pytest.raises(ValueError):
|
|
image_gen_registry.register_provider(Empty())
|
|
|
|
|
|
def test_list_is_sorted(self):
|
|
image_gen_registry.register_provider(_FakeProvider("zeta"))
|
|
image_gen_registry.register_provider(_FakeProvider("alpha"))
|
|
names = [p.name for p in image_gen_registry.list_providers()]
|
|
assert names == ["alpha", "zeta"]
|
|
|
|
|
|
class TestGetActiveProvider:
|
|
|
|
|
|
def test_explicit_config_wins(self, tmp_path, monkeypatch):
|
|
import yaml
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
(tmp_path / "config.yaml").write_text(
|
|
yaml.safe_dump({"image_gen": {"provider": "openai"}})
|
|
)
|
|
image_gen_registry.register_provider(_FakeProvider("fal"))
|
|
image_gen_registry.register_provider(_FakeProvider("openai"))
|
|
active = image_gen_registry.get_active_provider()
|
|
assert active is not None and active.name == "openai"
|
|
|
|
|
|
def test_none_when_empty(self, tmp_path, monkeypatch):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
assert image_gen_registry.get_active_provider() is None
|