mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
60 lines
2.2 KiB
Python
60 lines
2.2 KiB
Python
"""Tests for get_tool_emoji in agent/display.py — skin + registry integration."""
|
|
|
|
from unittest.mock import patch as mock_patch, MagicMock
|
|
|
|
from agent.display import get_tool_emoji
|
|
|
|
|
|
class TestGetToolEmoji:
|
|
"""Verify the skin → registry → fallback resolution chain."""
|
|
|
|
|
|
|
|
|
|
|
|
def test_custom_default(self):
|
|
"""Custom default is returned when nothing matches."""
|
|
with mock_patch("agent.display._get_skin", return_value=None):
|
|
mock_reg = MagicMock()
|
|
mock_reg.get_emoji.return_value = ""
|
|
import sys
|
|
mock_module = MagicMock()
|
|
mock_module.registry = mock_reg
|
|
with mock_patch.dict(sys.modules, {"tools.registry": mock_module}):
|
|
result = get_tool_emoji("x", default="⚙️")
|
|
assert result == "⚙️"
|
|
|
|
def test_skin_override_only_for_matching_tool(self):
|
|
"""Skin override for one tool doesn't affect others."""
|
|
skin = MagicMock()
|
|
skin.tool_emojis = {"terminal": "⚔"}
|
|
mock_reg = MagicMock()
|
|
mock_reg.get_emoji.return_value = "🔍"
|
|
import sys
|
|
mock_module = MagicMock()
|
|
mock_module.registry = mock_reg
|
|
with mock_patch("agent.display._get_skin", return_value=skin), \
|
|
mock_patch.dict(sys.modules, {"tools.registry": mock_module}):
|
|
assert get_tool_emoji("terminal") == "⚔" # skin override
|
|
assert get_tool_emoji("web_search") == "🔍" # registry fallback
|
|
|
|
|
|
class TestSkinConfigToolEmojis:
|
|
"""Verify SkinConfig handles tool_emojis field correctly."""
|
|
|
|
|
|
def test_skin_config_accepts_tool_emojis(self):
|
|
from hermes_cli.skin_engine import SkinConfig
|
|
emojis = {"terminal": "⚔", "web_search": "🔮"}
|
|
skin = SkinConfig(name="test", tool_emojis=emojis)
|
|
assert skin.tool_emojis == emojis
|
|
|
|
def test_build_skin_config_includes_tool_emojis(self):
|
|
from hermes_cli.skin_engine import _build_skin_config
|
|
data = {
|
|
"name": "custom",
|
|
"tool_emojis": {"terminal": "🗡️", "patch": "⚒️"},
|
|
}
|
|
skin = _build_skin_config(data)
|
|
assert skin.tool_emojis == {"terminal": "🗡️", "patch": "⚒️"}
|
|
|