mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
159 lines
5 KiB
Python
159 lines
5 KiB
Python
"""Tests for Arcee Trinity Large Thinking per-model overrides.
|
|
|
|
Arcee Trinity Large Thinking is a reasoning model that wants:
|
|
- Fixed temperature=0.5 (vs the global default)
|
|
- Compression threshold=0.75 (delay compression to preserve reasoning context)
|
|
|
|
The helpers must match the bare model name, including when it arrives via
|
|
OpenRouter as ``arcee-ai/trinity-large-thinking``, but must NOT hit sibling
|
|
Arcee models like trinity-large-preview or trinity-mini.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from agent.agent_init import _resolve_compression_threshold
|
|
from agent.auxiliary_client import (
|
|
_compression_threshold_for_model,
|
|
_fixed_temperature_for_model,
|
|
_is_arcee_trinity_thinking,
|
|
_is_codex_gpt54_or_gpt55,
|
|
_is_codex_spark,
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"model",
|
|
[
|
|
"trinity-large-thinking",
|
|
"arcee-ai/trinity-large-thinking",
|
|
"Arcee-AI/Trinity-Large-Thinking", # case-insensitive
|
|
" trinity-large-thinking ", # whitespace tolerant
|
|
],
|
|
)
|
|
def test_is_arcee_trinity_thinking_matches(model: str) -> None:
|
|
assert _is_arcee_trinity_thinking(model) is True
|
|
|
|
|
|
|
|
|
|
def test_fixed_temperature_for_trinity_thinking() -> None:
|
|
assert _fixed_temperature_for_model("trinity-large-thinking") == 0.5
|
|
assert _fixed_temperature_for_model("arcee-ai/trinity-large-thinking") == 0.5
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_compression_threshold_default_none_for_other_models() -> None:
|
|
# None means "leave the user's config value unchanged".
|
|
assert _compression_threshold_for_model(None) is None
|
|
assert _compression_threshold_for_model("") is None
|
|
assert _compression_threshold_for_model("trinity-large-preview") is None
|
|
assert _compression_threshold_for_model("claude-sonnet-4.6") is None
|
|
assert _compression_threshold_for_model("kimi-k2") is None
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Codex gpt-5.4 / gpt-5.5 compaction-threshold autoraise
|
|
#
|
|
# ChatGPT's Codex OAuth backend caps both families at a 272K window (verified
|
|
# live via the Codex /models resolver and per-slug fallback table). The default
|
|
# 50% compaction trigger would fire at ~136K — half the usable window — so this
|
|
# route raises the trigger to 85%. Only the Codex OAuth route is affected; the
|
|
# same slugs on OpenAI direct / OpenRouter / Copilot expose a larger window and
|
|
# keep the user's global threshold.
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"model",
|
|
["gpt-5", "gpt-5.55", "gpt-5.50", "gpt-5.45", "gpt-5.40", "", None],
|
|
)
|
|
def test_is_codex_gpt54_or_gpt55_rejects_non_54_55_models(model) -> None:
|
|
# Close numeric neighbours must NOT match — the prefix guards require a
|
|
# separator after "5.4" / "5.5" so e.g. gpt-5.45 and gpt-5.55 stay out.
|
|
assert _is_codex_gpt54_or_gpt55(model, "openai-codex") is False
|
|
|
|
|
|
def test_compression_threshold_for_codex_gpt55() -> None:
|
|
assert _compression_threshold_for_model("gpt-5.4", "openai-codex") == 0.85
|
|
assert _compression_threshold_for_model("gpt-5.4-pro", "openai-codex") == 0.85
|
|
assert _compression_threshold_for_model("openai/gpt-5.4", "openai-codex") == 0.85
|
|
assert _compression_threshold_for_model("gpt-5.5", "openai-codex") == 0.85
|
|
assert _compression_threshold_for_model("gpt-5.5-pro", "openai-codex") == 0.85
|
|
assert _compression_threshold_for_model("openai/gpt-5.5", "openai-codex") == 0.85
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Codex gpt-5.3-codex-spark compaction-threshold autoraise
|
|
#
|
|
# gpt-5.3-codex-spark is Codex-OAuth-only (ChatGPT Pro entitlement) with a
|
|
# native 128K context window. The default 50% compaction trigger would fire
|
|
# at ~64K — wasting half the usable window, often before the session has
|
|
# accumulated enough turns to summarize meaningfully. This route raises the
|
|
# trigger to 70% (~90K) to preserve more raw context while leaving ~38K
|
|
# headroom before the 128K hard limit.
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"model",
|
|
[
|
|
"gpt-5.5", # different family
|
|
"gpt-5.3-codex", # sibling, not spark
|
|
"gpt-5.3", # bare 5.3, not spark
|
|
"gpt-5.3-codex-spark-mini", # hypothetical variant — not matched yet
|
|
"", None,
|
|
],
|
|
)
|
|
def test_is_codex_spark_rejects_non_spark_models(model) -> None:
|
|
assert _is_codex_spark(model, "openai-codex") is False
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ── _resolve_compression_threshold (init_agent application logic) ────────────
|
|
#
|
|
# The Codex overrides are *autoraises*: they raise the trigger (0.85 for the
|
|
# gpt-5.4/5.5 272K family, 0.70 for spark) but must never LOWER a higher
|
|
# user-configured global threshold.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_resolve_no_override_keeps_global() -> None:
|
|
# No per-model override (model_cthresh is None) → global threshold, no notice.
|
|
effective, notice = _resolve_compression_threshold(
|
|
0.50, None, is_codex_autoraise=False
|
|
)
|
|
assert effective == 0.50
|
|
assert notice is None
|
|
|
|
|