mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
229 lines
6.7 KiB
Python
229 lines
6.7 KiB
Python
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
from agent import account_usage
|
|
|
|
|
|
class _FakeResponse:
|
|
def __init__(self, payload):
|
|
self._payload = payload
|
|
|
|
def raise_for_status(self):
|
|
return None
|
|
|
|
def json(self):
|
|
return self._payload
|
|
|
|
|
|
class _FakeClient:
|
|
def __init__(self, calls, payload):
|
|
self.calls = calls
|
|
self.payload = payload
|
|
|
|
def __enter__(self):
|
|
return self
|
|
|
|
def __exit__(self, *exc):
|
|
return False
|
|
|
|
def get(self, url, headers):
|
|
self.calls.append({"url": url, "headers": headers})
|
|
return _FakeResponse(self.payload)
|
|
|
|
|
|
@pytest.fixture
|
|
def codex_usage_payload():
|
|
return {
|
|
"plan_type": "plus",
|
|
"rate_limit": {
|
|
"primary_window": {
|
|
"used_percent": 21,
|
|
"reset_at": 1779846359,
|
|
},
|
|
"secondary_window": {
|
|
"used_percent": 4,
|
|
"reset_at": 1780230796,
|
|
},
|
|
},
|
|
"credits": {"has_credits": False},
|
|
}
|
|
|
|
|
|
def test_codex_usage_prefers_explicit_live_agent_credentials(monkeypatch, codex_usage_payload):
|
|
calls = []
|
|
monkeypatch.setattr(
|
|
account_usage.httpx,
|
|
"Client",
|
|
lambda timeout: _FakeClient(calls, codex_usage_payload),
|
|
)
|
|
monkeypatch.setattr(
|
|
account_usage,
|
|
"resolve_codex_runtime_credentials",
|
|
lambda **kwargs: (_ for _ in ()).throw(AssertionError("legacy auth should not be used")),
|
|
)
|
|
|
|
snapshot = account_usage.fetch_account_usage(
|
|
"openai-codex",
|
|
base_url="https://chatgpt.com/backend-api/codex",
|
|
api_key="live-agent-token",
|
|
)
|
|
|
|
assert snapshot is not None
|
|
assert snapshot.provider == "openai-codex"
|
|
assert snapshot.plan == "Plus"
|
|
assert [w.label for w in snapshot.windows] == ["Session", "Weekly"]
|
|
assert snapshot.windows[0].used_percent == 21
|
|
assert calls[0]["url"] == "https://chatgpt.com/backend-api/wham/usage"
|
|
assert calls[0]["headers"]["Authorization"] == "Bearer live-agent-token"
|
|
|
|
|
|
def test_codex_usage_falls_back_to_native_credential_pool(monkeypatch, codex_usage_payload):
|
|
calls = []
|
|
monkeypatch.setattr(
|
|
account_usage.httpx,
|
|
"Client",
|
|
lambda timeout: _FakeClient(calls, codex_usage_payload),
|
|
)
|
|
# Pool fallback fires only on AuthError (the documented "no creds" mode of
|
|
# the resolver), NOT on arbitrary exceptions — see the transient-error guard
|
|
# test below.
|
|
monkeypatch.setattr(
|
|
account_usage,
|
|
"resolve_codex_runtime_credentials",
|
|
lambda **kwargs: (_ for _ in ()).throw(
|
|
account_usage.AuthError("no singleton auth", provider="openai-codex", code="codex_auth_missing")
|
|
),
|
|
)
|
|
|
|
pool_entry = SimpleNamespace(
|
|
runtime_api_key="pooled-token",
|
|
runtime_base_url="https://chatgpt.com/backend-api/codex",
|
|
)
|
|
pool = SimpleNamespace(select=lambda: pool_entry)
|
|
|
|
import agent.credential_pool as credential_pool
|
|
|
|
monkeypatch.setattr(credential_pool, "load_pool", lambda provider: pool)
|
|
|
|
snapshot = account_usage.fetch_account_usage("openai-codex")
|
|
|
|
assert snapshot is not None
|
|
assert snapshot.windows[0].label == "Session"
|
|
assert snapshot.windows[1].label == "Weekly"
|
|
assert calls[0]["url"] == "https://chatgpt.com/backend-api/wham/usage"
|
|
assert calls[0]["headers"]["Authorization"] == "Bearer pooled-token"
|
|
# Pool creds have no account_id concept — the ChatGPT-Account-Id header must
|
|
# be omitted rather than sent stale/wrong.
|
|
assert "ChatGPT-Account-Id" not in calls[0]["headers"]
|
|
|
|
|
|
|
|
|
|
def test_codex_usage_account_id_read_failure_keeps_singleton_token(monkeypatch, codex_usage_payload):
|
|
"""When the resolver succeeds but the separate account_id read raises, the
|
|
working singleton token must still be used (best-effort account_id), NOT
|
|
abandoned in favor of a header-less pool credential."""
|
|
calls = []
|
|
monkeypatch.setattr(
|
|
account_usage.httpx,
|
|
"Client",
|
|
lambda timeout: _FakeClient(calls, codex_usage_payload),
|
|
)
|
|
monkeypatch.setattr(
|
|
account_usage,
|
|
"resolve_codex_runtime_credentials",
|
|
lambda **kwargs: {
|
|
"api_key": "singleton-token",
|
|
"base_url": "https://chatgpt.com/backend-api/codex",
|
|
},
|
|
)
|
|
monkeypatch.setattr(
|
|
account_usage,
|
|
"_read_codex_tokens",
|
|
lambda *a, **k: (_ for _ in ()).throw(
|
|
account_usage.AuthError("partial store", provider="openai-codex", code="codex_auth_invalid_shape")
|
|
),
|
|
)
|
|
|
|
import agent.credential_pool as credential_pool
|
|
|
|
monkeypatch.setattr(
|
|
credential_pool,
|
|
"load_pool",
|
|
lambda provider: (_ for _ in ()).throw(AssertionError("pool must not be consulted")),
|
|
)
|
|
|
|
snapshot = account_usage.fetch_account_usage("openai-codex")
|
|
|
|
assert snapshot is not None
|
|
assert calls[0]["headers"]["Authorization"] == "Bearer singleton-token"
|
|
# account_id read failed → header omitted, but the singleton token is kept.
|
|
assert "ChatGPT-Account-Id" not in calls[0]["headers"]
|
|
|
|
|
|
|
|
|
|
# ── Banked rate-limit reset credits (`/usage reset`) ─────────────────────────
|
|
|
|
|
|
class _FakeResetClient:
|
|
"""GET returns the usage payload; POST returns the consume payload."""
|
|
|
|
def __init__(self, calls, usage_payload, consume_payload=None):
|
|
self.calls = calls
|
|
self.usage_payload = usage_payload
|
|
self.consume_payload = consume_payload or {}
|
|
|
|
def __enter__(self):
|
|
return self
|
|
|
|
def __exit__(self, *exc):
|
|
return False
|
|
|
|
def get(self, url, headers):
|
|
self.calls.append({"method": "GET", "url": url, "headers": headers})
|
|
return _FakeResponse(self.usage_payload)
|
|
|
|
def post(self, url, headers=None, json=None):
|
|
self.calls.append({"method": "POST", "url": url, "headers": headers, "json": json})
|
|
return _FakeResponse(self.consume_payload)
|
|
|
|
|
|
def _usage_payload_with_resets(primary_used, secondary_used, banked):
|
|
return {
|
|
"plan_type": "plus",
|
|
"rate_limit": {
|
|
"primary_window": {"used_percent": primary_used, "reset_at": 1779846359},
|
|
"secondary_window": {"used_percent": secondary_used, "reset_at": 1780230796},
|
|
},
|
|
"rate_limit_reset_credits": {"available_count": banked},
|
|
"credits": {"has_credits": False},
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_redeem_missing_credentials_reports_unavailable(monkeypatch):
|
|
monkeypatch.setattr(
|
|
account_usage,
|
|
"_resolve_codex_usage_credentials",
|
|
lambda base_url, api_key: (_ for _ in ()).throw(RuntimeError("no creds")),
|
|
)
|
|
|
|
result = account_usage.redeem_codex_reset_credit()
|
|
|
|
assert result.status == "unavailable"
|
|
assert "hermes auth" in result.message
|