mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
80 lines
2.6 KiB
Python
80 lines
2.6 KiB
Python
"""Tests for ACP session-provenance derivation (issue #33617).
|
|
|
|
Exercises acp_adapter.provenance against a real SessionDB — no mocks — covering
|
|
the acceptance-criteria matrix: root session, compression-split continuation,
|
|
multi-depth chains, rotation flagging, and graceful handling of unknown ids.
|
|
"""
|
|
|
|
import time
|
|
|
|
import pytest
|
|
|
|
from acp_adapter.provenance import build_session_provenance, session_provenance_meta
|
|
from hermes_state import SessionDB
|
|
|
|
|
|
@pytest.fixture()
|
|
def db(tmp_path):
|
|
d = SessionDB(db_path=tmp_path / "state.db")
|
|
yield d
|
|
|
|
|
|
def _mk(db, sid, parent=None):
|
|
db.create_session(session_id=sid, source="acp", parent_session_id=parent)
|
|
|
|
|
|
def test_root_session_no_compression(db):
|
|
_mk(db, "root1")
|
|
prov = build_session_provenance(db, "acp-1", "root1")
|
|
assert prov["acpSessionId"] == "acp-1"
|
|
assert prov["currentHermesSessionId"] == "root1"
|
|
assert prov["rootHermesSessionId"] == "root1"
|
|
assert prov["parentHermesSessionId"] is None
|
|
assert prov["sessionKind"] == "root"
|
|
assert prov["compressionDepth"] == 0
|
|
assert "reason" not in prov # no rotation signalled
|
|
|
|
|
|
def test_compression_split_continuation(db):
|
|
# Parent ended with compression, child created afterwards.
|
|
_mk(db, "old")
|
|
db.end_session("old", "compression")
|
|
time.sleep(0.001)
|
|
_mk(db, "new", parent="old")
|
|
|
|
prov = build_session_provenance(
|
|
db, "acp-1", "new", previous_hermes_session_id="old"
|
|
)
|
|
assert prov["sessionKind"] == "continuation"
|
|
assert prov["parentHermesSessionId"] == "old"
|
|
assert prov["rootHermesSessionId"] == "old"
|
|
assert prov["compressionDepth"] == 1
|
|
assert prov["previousHermesSessionId"] == "old"
|
|
# Head rotated this turn → reason/creatorKind flagged.
|
|
assert prov["reason"] == "compression"
|
|
assert prov["creatorKind"] == "compression"
|
|
|
|
|
|
|
|
|
|
def test_non_compression_parent_is_root_not_continuation(db):
|
|
# A child with a parent that did NOT end via compression (e.g. delegate
|
|
# or branch child) must not be reported as a compression continuation.
|
|
_mk(db, "p")
|
|
_mk(db, "c", parent="p") # parent still live, no end_reason
|
|
prov = build_session_provenance(db, "acp-1", "c")
|
|
assert prov["sessionKind"] == "root"
|
|
assert prov["compressionDepth"] == 0
|
|
assert prov["rootHermesSessionId"] == "p" # lineage root still walked
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_meta_wrapper_shape(db):
|
|
_mk(db, "root1")
|
|
meta = session_provenance_meta(db, "acp-1", "root1")
|
|
assert set(meta.keys()) == {"hermes"}
|
|
assert "sessionProvenance" in meta["hermes"]
|
|
assert meta["hermes"]["sessionProvenance"]["currentHermesSessionId"] == "root1"
|