mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
32 lines
1.1 KiB
Python
32 lines
1.1 KiB
Python
"""Shared fixtures for tests/acp.
|
|
|
|
Keeps the ACP server tests offline: ``HermesACPAgent._build_model_state``
|
|
calls ``hermes_cli.inventory.build_models_payload``, which (without this
|
|
fixture) performs live network fetches — models.dev registry, GitHub model
|
|
catalog, Copilot token exchange, Anthropic model list — adding ~3s of real
|
|
SSL/socket time to every test that creates or loads a session (~147s total
|
|
for test_server.py alone).
|
|
|
|
Tests that assert model-state behavior re-patch these same attributes with
|
|
``unittest.mock.patch`` / ``monkeypatch``; inner patches win, so this
|
|
default is transparent to them.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _offline_model_inventory(monkeypatch):
|
|
"""Stub the shared model inventory so ACP tests never hit the network."""
|
|
import hermes_cli.inventory as inventory
|
|
|
|
class _StubPickerContext:
|
|
def with_overrides(self, **_kwargs):
|
|
return self
|
|
|
|
monkeypatch.setattr(inventory, "load_picker_context", lambda: _StubPickerContext())
|
|
monkeypatch.setattr(
|
|
inventory,
|
|
"build_models_payload",
|
|
lambda *_args, **_kwargs: {"providers": []},
|
|
)
|